valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reasoning effort title (#4694)

Browse Source
This commit is contained in:
dedrisian-oai
2025-10-03 16:17:30 -07:00
committed by GitHub
parent 1b4a79f03c
commit fae0e6c52c
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-rs/tui/src/chatwidget.rs
View File

@@ -1640,9 +1640,9 @@ impl ChatWidget {
} }
self.bottom_pane.show_selection_view(SelectionViewParams { self.bottom_pane.show_selection_view(SelectionViewParams {
title: Some("Select Model".to_string()), title: Some("Select Model and Effort".to_string()),
subtitle: Some("Switch the model for this and future Codex CLI sessions".to_string()), subtitle: Some("Switch the model for this and future Codex CLI sessions".to_string()),
footer_hint: Some(standard_popup_hint_line()), footer_hint: Some("Press enter to select reasoning effort, or esc to dismiss.".into()),
items, items,
..Default::default() ..Default::default()
}); });

4
codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_selection_popup.snap
View File

@@ -2,11 +2,11 @@
source: tui/src/chatwidget/tests.rs source: tui/src/chatwidget/tests.rs
expression: popup expression: popup
--- ---
Select Model Select Model and Effort
Switch the model for this and future Codex CLI sessions Switch the model for this and future Codex CLI sessions
› 1. gpt-5-codex (current) Optimized for coding tasks with many tools. › 1. gpt-5-codex (current) Optimized for coding tasks with many tools.
2. gpt-5 Broad world knowledge with strong general 2. gpt-5 Broad world knowledge with strong general
reasoning. reasoning.
Press enter to confirm or esc to go back Press enter to select reasoning effort, or esc to dismiss.

2
codex-rs/tui/src/chatwidget/tests.rs
View File

@@ -1046,7 +1046,7 @@ fn reasoning_popup_escape_returns_to_model_popup() {
chat.handle_key_event(KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE)); chat.handle_key_event(KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE));
let after_escape = render_bottom_popup(&chat, 80); let after_escape = render_bottom_popup(&chat, 80);
assert!(after_escape.contains("Select Model")); assert!(after_escape.contains("Select Model and Effort"));
assert!(!after_escape.contains("Select Reasoning Level")); assert!(!after_escape.contains("Select Reasoning Level"));
} }