From fae0e6c52c7da6786700a85ed7cd90925684ff73 Mon Sep 17 00:00:00 2001 From: dedrisian-oai Date: Fri, 3 Oct 2025 16:17:30 -0700 Subject: [PATCH] Fix reasoning effort title (#4694) --- codex-rs/tui/src/chatwidget.rs | 4 ++-- .../codex_tui__chatwidget__tests__model_selection_popup.snap | 4 ++-- codex-rs/tui/src/chatwidget/tests.rs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs index 79ee810f..2237c678 100644 --- a/codex-rs/tui/src/chatwidget.rs +++ b/codex-rs/tui/src/chatwidget.rs @@ -1640,9 +1640,9 @@ impl ChatWidget { } self.bottom_pane.show_selection_view(SelectionViewParams { - title: Some("Select Model".to_string()), + title: Some("Select Model and Effort".to_string()), subtitle: Some("Switch the model for this and future Codex CLI sessions".to_string()), - footer_hint: Some(standard_popup_hint_line()), + footer_hint: Some("Press enter to select reasoning effort, or esc to dismiss.".into()), items, ..Default::default() }); diff --git a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_selection_popup.snap b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_selection_popup.snap index 60c88682..d4ca0491 100644 --- a/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_selection_popup.snap +++ b/codex-rs/tui/src/chatwidget/snapshots/codex_tui__chatwidget__tests__model_selection_popup.snap @@ -2,11 +2,11 @@ source: tui/src/chatwidget/tests.rs expression: popup --- - Select Model + Select Model and Effort Switch the model for this and future Codex CLI sessions › 1. gpt-5-codex (current) Optimized for coding tasks with many tools. 2. gpt-5 Broad world knowledge with strong general reasoning. - Press enter to confirm or esc to go back + Press enter to select reasoning effort, or esc to dismiss. diff --git a/codex-rs/tui/src/chatwidget/tests.rs b/codex-rs/tui/src/chatwidget/tests.rs index ef24c82f..a17e0a75 100644 --- a/codex-rs/tui/src/chatwidget/tests.rs +++ b/codex-rs/tui/src/chatwidget/tests.rs @@ -1046,7 +1046,7 @@ fn reasoning_popup_escape_returns_to_model_popup() { chat.handle_key_event(KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE)); let after_escape = render_bottom_popup(&chat, 80); - assert!(after_escape.contains("Select Model")); + assert!(after_escape.contains("Select Model and Effort")); assert!(!after_escape.contains("Select Reasoning Level")); }