valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix bug when resizing to a smaller width (#4248)

Browse Source 
The composer and key hint lines were using line styles, causing ratatui
to print spaces all the way to the right side of the terminal. this
meant that resizing the terminal to be narrower would result in
rewrapping those lines, causing the bottom area to rerender and push all
content up.

Before


https://github.com/user-attachments/assets/8b14555a-1fc5-4f78-8df7-1410ee25e07a

After


https://github.com/user-attachments/assets/707645ab-89c7-4c7f-b556-02f53cef8a2f
This commit is contained in:
Jeremy Rose
2025-09-25 14:17:13 -07:00
committed by GitHub
parent 4a5f05c136
commit affb5fc1d0
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
codex-rs/tui/src/bottom_pane/chat_composer.rs
View File

@@ -1330,9 +1330,11 @@ impl WidgetRef for ChatComposer {
}
}
Line::from(hint)
.style(Style::default().dim())
.render_ref(hint_rect, buf);
let hint = hint
.into_iter()
.map(|span| span.patch_style(Style::default().dim()))
.collect::<Vec<_>>();
Line::from(hint).render_ref(hint_rect, buf);
}
}
let border_style = if self.has_focus {
@@ -1356,9 +1358,8 @@ impl WidgetRef for ChatComposer {
let mut state = self.textarea_state.borrow_mut();
StatefulWidgetRef::render_ref(&(&self.textarea), textarea_rect, buf, &mut state);
if self.textarea.text().is_empty() {
Line::from(self.placeholder_text.as_str())
.style(Style::default().dim())
.render_ref(textarea_rect.inner(Margin::new(0, 0)), buf);
let placeholder = Span::from(self.placeholder_text.as_str()).dim();
Line::from(vec![placeholder]).render_ref(textarea_rect.inner(Margin::new(0, 0)), buf);
}
}
}