remove triaging labels section + avoid capturing exitOnCtrlC for full-context mode
Signed-off-by: Thibault Sottiaux <tibo@openai.com>
This commit is contained in:
committed by
GitHub
parent
1b40e19baf
commit
4ad39fc4e1
44
README.md
44
README.md
@@ -10,20 +10,30 @@
|
|||||||
<details>
|
<details>
|
||||||
<summary><strong>Table of Contents</strong></summary>
|
<summary><strong>Table of Contents</strong></summary>
|
||||||
|
|
||||||
1. [Quickstart](#quickstart)
|
- [Quickstart](#quickstart)
|
||||||
1. [Why Codex?](#why-codex)
|
- [Why Codex?](#whycodex)
|
||||||
1. [Features](#features)
|
- [Security Model \& Permissions](#securitymodelpermissions)
|
||||||
1. [System Requirements](#system-requirements)
|
- [Platform sandboxing details](#platform-sandboxing-details)
|
||||||
1. [Security Model & Permissions](#security-model--permissions)
|
- [System Requirements](#systemrequirements)
|
||||||
1. [CLI Reference](#cli-reference)
|
- [CLI Reference](#clireference)
|
||||||
1. [Memory & Project Docs](#memory--project-docs)
|
- [Memory \& Project Docs](#memoryprojectdocs)
|
||||||
1. [Non‑interactive / CI mode](#non‑interactive--ci-mode)
|
- [Non‑interactive / CI mode](#noninteractivecimode)
|
||||||
1. [Recipes](#recipes)
|
- [Recipes](#recipes)
|
||||||
1. [Installation](#installation)
|
- [Installation](#installation)
|
||||||
1. [FAQ](#faq)
|
- [Configuration](#configuration)
|
||||||
1. [Contributing](#contributing)
|
- [FAQ](#faq)
|
||||||
1. [Security & Responsible AI](#security--responsible-ai)
|
- [Contributing](#contributing)
|
||||||
1. [License](#license)
|
- [Development workflow](#development-workflow)
|
||||||
|
- [Writing high‑impact code changes](#writing-highimpact-code-changes)
|
||||||
|
- [Opening a pull request](#opening-a-pull-request)
|
||||||
|
- [Review process](#review-process)
|
||||||
|
- [Community values](#community-values)
|
||||||
|
- [Getting help](#getting-help)
|
||||||
|
- [Developer Certificate of Origin (DCO)](#developer-certificate-of-origin-dco)
|
||||||
|
- [How to sign (recommended flow)](#how-to-sign-recommended-flow)
|
||||||
|
- [Quick fixes](#quick-fixes)
|
||||||
|
- [Security \& Responsible AI](#securityresponsibleai)
|
||||||
|
- [License](#license)
|
||||||
|
|
||||||
</details>
|
</details>
|
||||||
|
|
||||||
@@ -315,12 +325,6 @@ npm run format:fix
|
|||||||
2. We may ask for changes – please do not take this personally. We value the work, we just also value consistency and long‑term maintainability.
|
2. We may ask for changes – please do not take this personally. We value the work, we just also value consistency and long‑term maintainability.
|
||||||
3. When there is consensus that the PR meets the bar, a maintainer will squash‑and‑merge.
|
3. When there is consensus that the PR meets the bar, a maintainer will squash‑and‑merge.
|
||||||
|
|
||||||
### Triaging labels
|
|
||||||
|
|
||||||
- `good first issue` – great for newcomers, usually well‑scoped and low risk.
|
|
||||||
- `help wanted` – higher impact, still looking for outside contributors.
|
|
||||||
- `discussion` – exploring the problem/solution space; code contributions are discouraged until the direction is clear.
|
|
||||||
|
|
||||||
### Community values
|
### Community values
|
||||||
|
|
||||||
- **Be kind and inclusive.** Treat others with respect; we follow the [Contributor Covenant](https://www.contributor-covenant.org/).
|
- **Be kind and inclusive.** Treat others with respect; we follow the [Contributor Covenant](https://www.contributor-covenant.org/).
|
||||||
|
|||||||
@@ -14,14 +14,6 @@ export async function runSinglePass({
|
|||||||
rootPath: string;
|
rootPath: string;
|
||||||
}): Promise<void> {
|
}): Promise<void> {
|
||||||
return new Promise((resolve) => {
|
return new Promise((resolve) => {
|
||||||
// In full context mode we want to capture Ctrl+C ourselves so we can use it
|
|
||||||
// to interrupt long‑running requests without force‑quitting the whole
|
|
||||||
// process. Ink exits automatically when it detects Ctrl+C unless
|
|
||||||
// `exitOnCtrlC` is disabled via the render‑options, so make sure to turn it
|
|
||||||
// off here. All other keyboard handling (including optionally exiting when
|
|
||||||
// the user presses Ctrl+C while at the main prompt) is implemented inside
|
|
||||||
// `SinglePassApp`.
|
|
||||||
|
|
||||||
render(
|
render(
|
||||||
<SinglePassApp
|
<SinglePassApp
|
||||||
originalPrompt={originalPrompt}
|
originalPrompt={originalPrompt}
|
||||||
@@ -29,9 +21,6 @@ export async function runSinglePass({
|
|||||||
rootPath={rootPath}
|
rootPath={rootPath}
|
||||||
onExit={() => resolve()}
|
onExit={() => resolve()}
|
||||||
/>,
|
/>,
|
||||||
{
|
|
||||||
exitOnCtrlC: false,
|
|
||||||
},
|
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user