remove triaging labels section + avoid capturing exitOnCtrlC for full-context mode

Signed-off-by: Thibault Sottiaux <tibo@openai.com>
This commit is contained in:
Thibault Sottiaux
2025-04-16 10:41:44 -07:00
committed by GitHub
parent 1b40e19baf
commit 4ad39fc4e1
2 changed files with 24 additions and 31 deletions

View File

@@ -10,20 +10,30 @@
<details>
<summary><strong>Table&nbsp;of&nbsp;Contents</strong></summary>
1. [Quickstart](#quickstart)
1. [Why Codex?](#why-codex)
1. [Features](#features)
1. [System Requirements](#system-requirements)
1. [Security Model & Permissions](#security-model--permissions)
1. [CLI Reference](#cli-reference)
1. [Memory & Project Docs](#memory--project-docs)
1. [Noninteractive / CI mode](#noninteractive--ci-mode)
1. [Recipes](#recipes)
1. [Installation](#installation)
1. [FAQ](#faq)
1. [Contributing](#contributing)
1. [Security &amp; Responsible AI](#security--responsible-ai)
1. [License](#license)
- [Quickstart](#quickstart)
- [Why Codex?](#whycodex)
- [Security Model \& Permissions](#securitymodelpermissions)
- [Platform sandboxing details](#platform-sandboxing-details)
- [System Requirements](#systemrequirements)
- [CLI Reference](#clireference)
- [Memory \& Project Docs](#memoryprojectdocs)
- [Noninteractive / CI mode](#noninteractivecimode)
- [Recipes](#recipes)
- [Installation](#installation)
- [Configuration](#configuration)
- [FAQ](#faq)
- [Contributing](#contributing)
- [Development workflow](#development-workflow)
- [Writing highimpact code changes](#writing-highimpact-code-changes)
- [Opening a pull request](#opening-a-pull-request)
- [Review process](#review-process)
- [Community values](#community-values)
- [Getting help](#getting-help)
- [Developer Certificate of Origin (DCO)](#developer-certificate-of-origin-dco)
- [How to sign (recommended flow)](#how-to-sign-recommended-flow)
- [Quick fixes](#quick-fixes)
- [Security \& Responsible AI](#securityresponsibleai)
- [License](#license)
</details>
@@ -315,12 +325,6 @@ npm run format:fix
2. We may ask for changes please do not take this personally. We value the work, we just also value consistency and longterm maintainability.
3. When there is consensus that the PR meets the bar, a maintainer will squashandmerge.
### Triaging labels
- `good first issue` great for newcomers, usually wellscoped and low risk.
- `help wanted` higher impact, still looking for outside contributors.
- `discussion` exploring the problem/solution space; code contributions are discouraged until the direction is clear.
### Community values
- **Be kind and inclusive.** Treat others with respect; we follow the [Contributor Covenant](https://www.contributor-covenant.org/).

View File

@@ -14,14 +14,6 @@ export async function runSinglePass({
rootPath: string;
}): Promise<void> {
return new Promise((resolve) => {
// In full context mode we want to capture Ctrl+C ourselves so we can use it
// to interrupt longrunning requests without forcequitting the whole
// process. Ink exits automatically when it detects Ctrl+C unless
// `exitOnCtrlC` is disabled via the renderoptions, so make sure to turn it
// off here. All other keyboard handling (including optionally exiting when
// the user presses Ctrl+C while at the main prompt) is implemented inside
// `SinglePassApp`.
render(
<SinglePassApp
originalPrompt={originalPrompt}
@@ -29,9 +21,6 @@ export async function runSinglePass({
rootPath={rootPath}
onExit={() => resolve()}
/>,
{
exitOnCtrlC: false,
},
);
});
}