valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix outstanding review comments from the bot on #1919 (#1928)

Browse Source 
I should have read the comments before submitting!
This commit is contained in:
Michael Bolin
2025-08-07 01:30:13 -07:00
committed by GitHub
parent 0334476894
commit 13982d6b4e
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
codex-rs/config.md
View File

@@ -276,7 +276,7 @@ sandbox_mode = "workspace-write"
# Extra settings that only apply when `sandbox = "workspace-write"`. # Extra settings that only apply when `sandbox = "workspace-write"`.
[sandbox_workspace_write] [sandbox_workspace_write]
# By default, the cwd for the Codex session will be writable as well as $TMPDIR # By default, the cwd for the Codex session will be writable as well as $TMPDIR
# if set) and /tmp (if it exists). Setting the respective options to `true` # (if set) and /tmp (if it exists). Setting the respective options to `true`
# will override those defaults. # will override those defaults.
exclude_tmpdir_env_var = false exclude_tmpdir_env_var = false
exclude_slash_tmp = false exclude_slash_tmp = false

6
codex-rs/core/src/config.rs
View File

@@ -4,7 +4,7 @@ use crate::config_types::McpServerConfig;
use crate::config_types::ReasoningEffort; use crate::config_types::ReasoningEffort;
use crate::config_types::ReasoningSummary; use crate::config_types::ReasoningSummary;
use crate::config_types::SandboxMode; use crate::config_types::SandboxMode;
use crate::config_types::SandboxWorkplaceWrite; use crate::config_types::SandboxWorkspaceWrite;
use crate::config_types::ShellEnvironmentPolicy; use crate::config_types::ShellEnvironmentPolicy;
use crate::config_types::ShellEnvironmentPolicyToml; use crate::config_types::ShellEnvironmentPolicyToml;
use crate::config_types::Tui; use crate::config_types::Tui;
@@ -282,7 +282,7 @@ pub struct ConfigToml {
pub sandbox_mode: Option<SandboxMode>, pub sandbox_mode: Option<SandboxMode>,
/// Sandbox configuration to apply if `sandbox` is `WorkspaceWrite`. /// Sandbox configuration to apply if `sandbox` is `WorkspaceWrite`.
pub sandbox_workspace_write: Option<SandboxWorkplaceWrite>, pub sandbox_workspace_write: Option<SandboxWorkspaceWrite>,
/// Disable server-side response storage (sends the full conversation /// Disable server-side response storage (sends the full conversation
/// context with every request). Currently necessary for OpenAI customers /// context with every request). Currently necessary for OpenAI customers
@@ -361,7 +361,7 @@ impl ConfigToml {
match resolved_sandbox_mode { match resolved_sandbox_mode {
SandboxMode::ReadOnly => SandboxPolicy::new_read_only_policy(), SandboxMode::ReadOnly => SandboxPolicy::new_read_only_policy(),
SandboxMode::WorkspaceWrite => match self.sandbox_workspace_write.as_ref() { SandboxMode::WorkspaceWrite => match self.sandbox_workspace_write.as_ref() {
Some(SandboxWorkplaceWrite { Some(SandboxWorkspaceWrite {
writable_roots, writable_roots,
network_access, network_access,
exclude_tmpdir_env_var, exclude_tmpdir_env_var,

2
codex-rs/core/src/config_types.rs
View File

@@ -93,7 +93,7 @@ pub enum SandboxMode {
} }
#[derive(Deserialize, Debug, Clone, PartialEq, Default)] #[derive(Deserialize, Debug, Clone, PartialEq, Default)]
pub struct SandboxWorkplaceWrite { pub struct SandboxWorkspaceWrite {
#[serde(default)] #[serde(default)]
pub writable_roots: Vec<PathBuf>, pub writable_roots: Vec<PathBuf>,
#[serde(default)] #[serde(default)]