From 13982d6b4e79415ffa435af1cb0f584807062275 Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Thu, 7 Aug 2025 01:30:13 -0700 Subject: [PATCH] chore: fix outstanding review comments from the bot on #1919 (#1928) I should have read the comments before submitting! --- codex-rs/config.md | 2 +- codex-rs/core/src/config.rs | 6 +++--- codex-rs/core/src/config_types.rs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/codex-rs/config.md b/codex-rs/config.md index e0446844..68687c56 100644 --- a/codex-rs/config.md +++ b/codex-rs/config.md @@ -276,7 +276,7 @@ sandbox_mode = "workspace-write" # Extra settings that only apply when `sandbox = "workspace-write"`. [sandbox_workspace_write] # By default, the cwd for the Codex session will be writable as well as $TMPDIR -# if set) and /tmp (if it exists). Setting the respective options to `true` +# (if set) and /tmp (if it exists). Setting the respective options to `true` # will override those defaults. exclude_tmpdir_env_var = false exclude_slash_tmp = false diff --git a/codex-rs/core/src/config.rs b/codex-rs/core/src/config.rs index a2e0618a..081306da 100644 --- a/codex-rs/core/src/config.rs +++ b/codex-rs/core/src/config.rs @@ -4,7 +4,7 @@ use crate::config_types::McpServerConfig; use crate::config_types::ReasoningEffort; use crate::config_types::ReasoningSummary; use crate::config_types::SandboxMode; -use crate::config_types::SandboxWorkplaceWrite; +use crate::config_types::SandboxWorkspaceWrite; use crate::config_types::ShellEnvironmentPolicy; use crate::config_types::ShellEnvironmentPolicyToml; use crate::config_types::Tui; @@ -282,7 +282,7 @@ pub struct ConfigToml { pub sandbox_mode: Option, /// Sandbox configuration to apply if `sandbox` is `WorkspaceWrite`. - pub sandbox_workspace_write: Option, + pub sandbox_workspace_write: Option, /// Disable server-side response storage (sends the full conversation /// context with every request). Currently necessary for OpenAI customers @@ -361,7 +361,7 @@ impl ConfigToml { match resolved_sandbox_mode { SandboxMode::ReadOnly => SandboxPolicy::new_read_only_policy(), SandboxMode::WorkspaceWrite => match self.sandbox_workspace_write.as_ref() { - Some(SandboxWorkplaceWrite { + Some(SandboxWorkspaceWrite { writable_roots, network_access, exclude_tmpdir_env_var, diff --git a/codex-rs/core/src/config_types.rs b/codex-rs/core/src/config_types.rs index a81c2050..d584a049 100644 --- a/codex-rs/core/src/config_types.rs +++ b/codex-rs/core/src/config_types.rs @@ -93,7 +93,7 @@ pub enum SandboxMode { } #[derive(Deserialize, Debug, Clone, PartialEq, Default)] -pub struct SandboxWorkplaceWrite { +pub struct SandboxWorkspaceWrite { #[serde(default)] pub writable_roots: Vec, #[serde(default)]