valknar/home
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(stacks): surface pull failures and log before/after image IDs on mismatch

Browse Source 
update run silently swallowed pull errors and never logged what actually
differed, making a recurring false "updates found" for pulsenode (no
registry-side change since Aug 19) impossible to diagnose.
This commit is contained in:
valknar
2026-08-22 09:22:13 +02:00
parent 7584da9115
commit db4fc948d8
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/stacks
+5 -1
View File
@@ -417,11 +417,15 @@ _update_run() {
local before after local before after
before=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true before=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true
(cd "$stack_dir" && docker compose "${env_flag[@]}" pull 2>&1) || true if ! (cd "$stack_dir" && docker compose "${env_flag[@]}" pull 2>&1); then
warn " Pull reported a non-zero exit for $stack (see output above) — comparison may be unreliable"
fi
after=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true after=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true
if [[ "$before" != "$after" ]]; then if [[ "$before" != "$after" ]]; then
info " Updates found — recreating $stack" info " Updates found — recreating $stack"
info " before: ${before:-<empty>}"
info " after: ${after:-<empty>}"
if (cd "$stack_dir" && docker compose "${env_flag[@]}" up -d 2>&1); then if (cd "$stack_dir" && docker compose "${env_flag[@]}" up -d 2>&1); then
updated+=("$stack") updated+=("$stack")
ok " $stack updated" ok " $stack updated"