From db4fc948d82fd59dbef1967846feebf4eaaf1069 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Kr=C3=BCger?= Date: Sat, 22 Aug 2026 09:22:13 +0200 Subject: [PATCH] fix(stacks): surface pull failures and log before/after image IDs on mismatch update run silently swallowed pull errors and never logged what actually differed, making a recurring false "updates found" for pulsenode (no registry-side change since Aug 19) impossible to diagnose. --- bin/stacks | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bin/stacks b/bin/stacks index 98538f2..0135374 100755 --- a/bin/stacks +++ b/bin/stacks @@ -417,11 +417,15 @@ _update_run() { local before after before=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true - (cd "$stack_dir" && docker compose "${env_flag[@]}" pull 2>&1) || true + if ! (cd "$stack_dir" && docker compose "${env_flag[@]}" pull 2>&1); then + warn " Pull reported a non-zero exit for $stack (see output above) — comparison may be unreliable" + fi after=$(_stack_image_ids "$stack_dir" "${env_flag[@]+"${env_flag[@]}"}") || true if [[ "$before" != "$after" ]]; then info " Updates found — recreating $stack" + info " before: ${before:-}" + info " after: ${after:-}" if (cd "$stack_dir" && docker compose "${env_flag[@]}" up -d 2>&1); then updated+=("$stack") ok " $stack updated"