fix: resolve Apollo cache warning for TeamStats embedded objects

Add merge: true policy for Team.stats so InMemoryCache merges partial
TeamStats selections (e.g. search page) with fuller ones (team/stats pages)
instead of replacing and losing fields. Also align stats page query to
include goalDiff for consistency.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

app/stats/page.tsx

@@ -13,7 +13,7 @@ const STATS_QUERY = gql`
     }
     teams {
       id name iso2 slug
-      stats { appearances titles wins draws losses goalsFor goalsAgainst winPct }
+      stats { appearances titles wins draws losses goalsFor goalsAgainst goalDiff winPct }
     }
     goalsByMinute { bucket count }
     confederationStats { confederation appearances titles totalGoals }

app/teams/[slug]/page.tsx

@@ -56,18 +56,16 @@ export default function TeamPage({ params }: { params: Promise<{ slug: string }>
     skip: !team?.id,
   })
 
-  // Load all scorers to filter by team
   const { data: scorerData } = useQuery(gql`
-    query TeamScorers {
+    query TeamScorers($teamId: Int!) {
-      topScorers(limit: 200) {
+      topScorers(teamId: $teamId, limit: 30) {
         playerName goals penalties ownGoals tournaments
         team { id name iso2 }
       }
     }
-  `)
+  `, { variables: { teamId: team?.id ?? 0 }, skip: !team?.id })
 
-  const allScorers = scorerData?.topScorers ?? []
+  const teamScorers = scorerData?.topScorers ?? []
-  const teamScorers = team ? allScorers.filter((s: { team?: { id: number } | null }) => s.team?.id === team.id).slice(0, 15) : []
   const teamMatches: MatchRow[] = matchesData?.matches ?? []
 
   // Group matches by year for the history display

lib/graphql/client.ts

@@ -7,7 +7,11 @@ let client: InstanceType<typeof ApolloClient> | null = null
 function createClient() {
   return new ApolloClient({
     link: new HttpLink({ uri: '/api/graphql' }),
-    cache: new InMemoryCache(),
+    cache: new InMemoryCache({
+      typePolicies: {
+        Team: { fields: { stats: { merge: true } } },
+      },
+    }),
     defaultOptions: { watchQuery: { fetchPolicy: 'cache-and-network' } },
   })
 }

lib/graphql/resolvers/index.ts

@@ -152,11 +152,13 @@ export const resolvers = {
         return found ? teamWithSlug(found) : null
       } catch (e) { if (isMissingTable(e)) return null; throw e }
     },
-    async topScorers(_: unknown, { year, limit = 20 }: { year?: number; limit?: number }) {
+    async topScorers(_: unknown, { year, limit = 20, teamId }: { year?: number; limit?: number; teamId?: number }) {
       try {
-      const conditions = year
+      const conditions = sql`
-        ? sql`AND m.tournament_year = ${year} AND m.is_quali_playoff = false`
+        ${year ? sql`AND m.tournament_year = ${year}` : sql``}
-        : sql`AND m.is_quali_playoff = false`
+        ${teamId ? sql`AND g.team_id = ${teamId}` : sql``}
+        AND m.is_quali_playoff = false
+      `
       const rows = await db.execute(sql`
         SELECT
           g.player_name,

lib/graphql/schema.ts

@@ -170,7 +170,7 @@ export const typeDefs = /* GraphQL */ `
     teams: [Team!]!
     team(slug: String!): Team
 
-    topScorers(year: Int, limit: Int): [ScorerEntry!]!
+    topScorers(year: Int, limit: Int, teamId: Int): [ScorerEntry!]!
     player(name: String!): ScorerEntry
     hatTricks(year: Int): [HatTrick!]!