fix: scope team page scorers by teamId instead of filtering global top 200
Teams with few goals (e.g. Qatar) were missing from the sidebar because topScorers(limit:200) only returned all-time top scorers. Now the query filters by teamId in SQL so every team shows their own scorers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -56,18 +56,16 @@ export default function TeamPage({ params }: { params: Promise<{ slug: string }>
|
|||||||
skip: !team?.id,
|
skip: !team?.id,
|
||||||
})
|
})
|
||||||
|
|
||||||
// Load all scorers to filter by team
|
|
||||||
const { data: scorerData } = useQuery(gql`
|
const { data: scorerData } = useQuery(gql`
|
||||||
query TeamScorers {
|
query TeamScorers($teamId: Int!) {
|
||||||
topScorers(limit: 200) {
|
topScorers(teamId: $teamId, limit: 30) {
|
||||||
playerName goals penalties ownGoals tournaments
|
playerName goals penalties ownGoals tournaments
|
||||||
team { id name iso2 }
|
team { id name iso2 }
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
`)
|
`, { variables: { teamId: team?.id ?? 0 }, skip: !team?.id })
|
||||||
|
|
||||||
const allScorers = scorerData?.topScorers ?? []
|
const teamScorers = scorerData?.topScorers ?? []
|
||||||
const teamScorers = team ? allScorers.filter((s: { team?: { id: number } | null }) => s.team?.id === team.id).slice(0, 15) : []
|
|
||||||
const teamMatches: MatchRow[] = matchesData?.matches ?? []
|
const teamMatches: MatchRow[] = matchesData?.matches ?? []
|
||||||
|
|
||||||
// Group matches by year for the history display
|
// Group matches by year for the history display
|
||||||
|
|||||||
@@ -152,11 +152,13 @@ export const resolvers = {
|
|||||||
return found ? teamWithSlug(found) : null
|
return found ? teamWithSlug(found) : null
|
||||||
} catch (e) { if (isMissingTable(e)) return null; throw e }
|
} catch (e) { if (isMissingTable(e)) return null; throw e }
|
||||||
},
|
},
|
||||||
async topScorers(_: unknown, { year, limit = 20 }: { year?: number; limit?: number }) {
|
async topScorers(_: unknown, { year, limit = 20, teamId }: { year?: number; limit?: number; teamId?: number }) {
|
||||||
try {
|
try {
|
||||||
const conditions = year
|
const conditions = sql`
|
||||||
? sql`AND m.tournament_year = ${year} AND m.is_quali_playoff = false`
|
${year ? sql`AND m.tournament_year = ${year}` : sql``}
|
||||||
: sql`AND m.is_quali_playoff = false`
|
${teamId ? sql`AND g.team_id = ${teamId}` : sql``}
|
||||||
|
AND m.is_quali_playoff = false
|
||||||
|
`
|
||||||
const rows = await db.execute(sql`
|
const rows = await db.execute(sql`
|
||||||
SELECT
|
SELECT
|
||||||
g.player_name,
|
g.player_name,
|
||||||
|
|||||||
@@ -170,7 +170,7 @@ export const typeDefs = /* GraphQL */ `
|
|||||||
teams: [Team!]!
|
teams: [Team!]!
|
||||||
team(slug: String!): Team
|
team(slug: String!): Team
|
||||||
|
|
||||||
topScorers(year: Int, limit: Int): [ScorerEntry!]!
|
topScorers(year: Int, limit: Int, teamId: Int): [ScorerEntry!]!
|
||||||
player(name: String!): ScorerEntry
|
player(name: String!): ScorerEntry
|
||||||
hatTricks(year: Int): [HatTrick!]!
|
hatTricks(year: Int): [HatTrick!]!
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user