Compare commits

...
2 Commits
Author SHA1 Message Date
valknar 89d4d9b071 Bump @valknar/vpinball-wasm to 0.3.4
0.3.4 skips SDL_SetWindowIcon on the Emscripten target, so the engine no
longer hijacks the browser tab's favicon (and title) via a blob: URL
when a table loads — verified live, no app-side workaround needed.
2026-08-24 14:08:19 +02:00
valknar a2b929dbec Revert "Stop the pinball engine from hijacking the browser tab's favicon"
This reverts commit 4dd6d60457.
2026-08-24 13:52:38 +02:00
4 changed files with 7 additions and 34 deletions
-27
View File
@@ -61,32 +61,6 @@ export function usePinballInstance(
const canvas = canvasRef.current; const canvas = canvasRef.current;
if (!canvas || !webgl2Supported) return; if (!canvas || !webgl2Supported) return;
// The engine sets a table-supplied image as the page favicon via a
// blob: URL (see vpinball.js's rel~='icon' link handling) — undesirable
// here, where the app's own favicon should stay put. Snapshot the
// current icon links up front and revert any blob: href the moment it
// appears, rather than patching the (compiled) engine itself.
const originalIconHrefs = new Map<HTMLLinkElement, string>();
document.querySelectorAll<HTMLLinkElement>("link[rel~='icon']").forEach((link) => {
originalIconHrefs.set(link, link.href);
});
const faviconObserver = new MutationObserver(() => {
document.querySelectorAll<HTMLLinkElement>("link[rel~='icon']").forEach((link) => {
if (!link.href.startsWith("blob:")) return;
const blobUrl = link.href;
const original = originalIconHrefs.get(link);
if (original) link.href = original;
else link.remove();
URL.revokeObjectURL(blobUrl);
});
});
faviconObserver.observe(document.head, {
childList: true,
subtree: true,
attributes: true,
attributeFilter: ["href"],
});
setStatus("loading"); setStatus("loading");
const startedAt = performance.now(); const startedAt = performance.now();
@@ -129,7 +103,6 @@ export function usePinballInstance(
})(); })();
return () => { return () => {
faviconObserver.disconnect();
disposedRef.current = true; disposedRef.current = true;
const instance = instanceRef.current; const instance = instanceRef.current;
instanceRef.current = null; instanceRef.current = null;
+1 -1
View File
@@ -12,7 +12,7 @@
"lint": "eslint" "lint": "eslint"
}, },
"dependencies": { "dependencies": {
"@valknar/vpinball-wasm": "0.3.3", "@valknar/vpinball-wasm": "0.3.4",
"next": "16.3.2", "next": "16.3.2",
"react": "19.2.8", "react": "19.2.8",
"react-dom": "19.2.8" "react-dom": "19.2.8"
+5 -5
View File
@@ -9,8 +9,8 @@ importers:
.: .:
dependencies: dependencies:
'@valknar/vpinball-wasm': '@valknar/vpinball-wasm':
specifier: 0.3.3 specifier: 0.3.4
version: 0.3.3 version: 0.3.4
next: next:
specifier: 16.3.2 specifier: 16.3.2
version: 16.3.2(@babel/core@7.29.7(supports-color@7.2.0))(@types/node@20.19.43)(react-dom@19.2.8(react@19.2.8))(react@19.2.8) version: 16.3.2(@babel/core@7.29.7(supports-color@7.2.0))(@types/node@20.19.43)(react-dom@19.2.8(react@19.2.8))(react@19.2.8)
@@ -754,8 +754,8 @@ packages:
cpu: [x64] cpu: [x64]
os: [win32] os: [win32]
'@valknar/vpinball-wasm@0.3.3': '@valknar/vpinball-wasm@0.3.4':
resolution: {integrity: sha512-It2VO8FrmBa7u+aom4m+JCWaVv6ZOhRn0x8BqqrFbGo2ptTb64G8SgqRXuGU8GldhIvgl3/ug+PsSg3EhETZpg==, tarball: https://dev.pivoine.art/api/packages/valknar/npm/%40valknar%2Fvpinball-wasm/-/0.3.3/vpinball-wasm-0.3.3.tgz} resolution: {integrity: sha512-ULJ8jF3Q8sxmkkSdC70SSKzkvaNHORPZEFuJzQbmfH9aeqh4kYmqj59KX7bNywmAxLz4yLtr8r4i/oWEo8bbSw==, tarball: https://dev.pivoine.art/api/packages/valknar/npm/%40valknar%2Fvpinball-wasm/-/0.3.4/vpinball-wasm-0.3.4.tgz}
acorn-jsx@5.3.2: acorn-jsx@5.3.2:
resolution: {integrity: sha512-rq9s+JNhf0IChjtDXxllJ7g41oZk5SlXtp0LHwyA5cejwn7vKmKp4pPri6YEePv2PU65sAsegbXtIinmDFDXgQ==} resolution: {integrity: sha512-rq9s+JNhf0IChjtDXxllJ7g41oZk5SlXtp0LHwyA5cejwn7vKmKp4pPri6YEePv2PU65sAsegbXtIinmDFDXgQ==}
@@ -2645,7 +2645,7 @@ snapshots:
'@unrs/resolver-binding-win32-x64-msvc@1.12.2': '@unrs/resolver-binding-win32-x64-msvc@1.12.2':
optional: true optional: true
'@valknar/vpinball-wasm@0.3.3': {} '@valknar/vpinball-wasm@0.3.4': {}
acorn-jsx@5.3.2(acorn@8.18.0): acorn-jsx@5.3.2(acorn@8.18.0):
dependencies: dependencies:
+1 -1
View File
@@ -2,5 +2,5 @@ allowBuilds:
sharp: false sharp: false
unrs-resolver: false unrs-resolver: false
minimumReleaseAgeExclude: minimumReleaseAgeExclude:
- '@valknar/vpinball-wasm@0.2.0 || 0.3.1 || 0.3.2 || 0.3.3' - '@valknar/vpinball-wasm@0.2.0 || 0.3.1 || 0.3.2 || 0.3.3 || 0.3.4'
updateNotifier: false updateNotifier: false