9 Commits
Author SHA1 Message Date
valknar 1c21d2d79b chore: bump version to 0.3.4
CI / Build wasm engine (push) Successful in 7m54s
2026-08-24 13:57:30 +02:00
valknar f607992885 fix(vpinball): skip SDL_SetWindowIcon on the Emscripten target
SDL3's Emscripten video backend emulates SetWindowIcon by pointing the
page's <link rel="icon"> at a blob: URL of the encoded surface - a
reasonable desktop-icon mapping in general, but unwanted for an
embeddable widget where the host page already has its own favicon.
Verified via examples/basic: after this patch, no rel=icon link is
ever created/mutated while a table runs (previously a consumer had to
work around this with a MutationObserver reverting it every time).
2026-08-24 13:56:48 +02:00
valknar 10f32789e6 Trigger CI to verify simplified embedded-cache config
CI / Build wasm engine (push) Successful in 8m48s
2026-08-24 12:01:25 +02:00
valknar bf818bdd29 Trigger CI to verify gitea/runner migration + cache config fix
CI / Build wasm engine (push) Canceled after 4m37s
2026-08-24 11:56:29 +02:00
valknarandClaude Sonnet 5 4946dd2033 Trigger CI again after force-recreating the stale runner daemon
CI / Build wasm engine (push) Canceled after 1m16s
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 11:43:24 +02:00
valknarandClaude Sonnet 5 7e5793bb17 Trigger CI to test the dedicated cache-server setup
CI / Build wasm engine (push) Canceled after 4m13s
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 11:39:56 +02:00
valknarandClaude Sonnet 5 f52fa0cb79 Trigger CI with debug logging to capture the exact cache URL
CI / Build wasm engine (push) Successful in 11m17s
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 10:54:35 +02:00
valknarandClaude Sonnet 5 9c8afb7541 Trigger CI again to inspect the live job container's network
CI / Build wasm engine (push) Canceled after 5m3s
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 10:49:51 +02:00
valknarandClaude Sonnet 5 02f17165f2 Trigger CI to verify Gitea Actions cache fix (act_runner network/host config)
CI / Build wasm engine (push) Successful in 11m23s
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-24 10:33:08 +02:00
3 changed files with 28 additions and 3 deletions
+2 -2
View File
@@ -1,12 +1,12 @@
{
"name": "@valknar/vpinball-wasm",
"version": "0.3.3",
"version": "0.3.4",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@valknar/vpinball-wasm",
"version": "0.3.3",
"version": "0.3.4",
"license": "SEE LICENSE IN LICENSE",
"devDependencies": {
"typescript": "^5.6.0"
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "@valknar/vpinball-wasm",
"version": "0.3.3",
"version": "0.3.4",
"description": "Visual Pinball's engine compiled to WebAssembly - real .vpx tables, real VBScript, WebGL2 rendering, in the browser",
"license": "SEE LICENSE IN LICENSE",
"type": "module",
@@ -0,0 +1,25 @@
diff --git a/src/renderer/Window.cpp b/src/renderer/Window.cpp
index 3dff060..92a96df 100644
--- a/src/renderer/Window.cpp
+++ b/src/renderer/Window.cpp
@@ -264,6 +264,12 @@ Window::Window(const string& title, const Settings& settings, VPXWindowId window
m_pixelDensity = 1.f;
}
+#ifndef __EMSCRIPTEN__
+ // SDL3's Emscripten video backend emulates SDL_SetWindowIcon by pointing
+ // the page's <link rel="icon"> at a blob: URL of the encoded surface -
+ // a reasonable desktop-icon mapping in general, but unwanted here where
+ // the embedding page already has its own favicon. Skip it on this target
+ // rather than fight it from the host page's JS.
if (auto icon = BaseTexture::CreateFromFile(g_app->m_fileLocator.GetAppPath(FileLocator::AppSubFolder::Assets, "vpinball.png")); icon)
{
SDL_Surface* pSurface = icon->ToSDLSurface();
@@ -276,6 +282,7 @@ Window::Window(const string& title, const Settings& settings, VPXWindowId window
else {
PLOGE << "Failed to load window icon: " << SDL_GetError();
}
+#endif
// Check if the platform allows positioning windows (as Wayland forbids it...)
{