From 7b9283741fea93cf2c0ccff8bd60e9a7dbd30839 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Kr=C3=BCger?= Date: Sat, 21 Feb 2026 11:53:15 +0100 Subject: [PATCH] feat: revert back to static public environment variables --- REBUILD_GUIDE.md | 9 +++++---- packages/frontend/src/routes/+layout.svelte | 8 ++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/REBUILD_GUIDE.md b/REBUILD_GUIDE.md index a017c53..7dcdc6a 100644 --- a/REBUILD_GUIDE.md +++ b/REBUILD_GUIDE.md @@ -6,8 +6,9 @@ SvelteKit's `PUBLIC_*` environment variables are **baked into the JavaScript** a 1. ✅ Changing `PUBLIC_API_URL` 2. ✅ Changing `PUBLIC_URL` -3. ❌ NOT needed for `PUBLIC_UMAMI_ID` or `PUBLIC_UMAMI_SCRIPT` (those are runtime) -4. ❌ NOT needed for Directus env vars (those are runtime) +3. ✅ Changing `PUBLIC_UMAMI_ID` +4. ✅ Changing `PUBLIC_UMAMI_SCRIPT` +5. ❌ NOT needed for Directus env vars (those are runtime) ## Quick Rebuild Process @@ -23,7 +24,6 @@ Set your production values: ```bash PUBLIC_API_URL=https://sexy.pivoine.art/api PUBLIC_URL=https://sexy.pivoine.art -# Note: PUBLIC_UMAMI_* can also be set at runtime in docker-compose PUBLIC_UMAMI_ID=your-umami-id PUBLIC_UMAMI_SCRIPT=https://umami.pivoine.art/script.js ``` @@ -251,7 +251,8 @@ These are runtime environment variables and can be changed in docker-compose. |--------|----------------|--------------| | `PUBLIC_API_URL` | ✅ Yes | Rebuild image | | `PUBLIC_URL` | ✅ Yes | Rebuild image | -| `PUBLIC_UMAMI_*` | ❌ No | Restart container | +| `PUBLIC_UMAMI_ID` | ✅ Yes | Rebuild image | +| `PUBLIC_UMAMI_SCRIPT` | ✅ Yes | Rebuild image | | `SEXY_DIRECTUS_*` | ❌ No | Restart container | | `DB_*` | ❌ No | Restart container | | `EMAIL_*` | ❌ No | Restart container | diff --git a/packages/frontend/src/routes/+layout.svelte b/packages/frontend/src/routes/+layout.svelte index 4aa8c04..6cc3b93 100644 --- a/packages/frontend/src/routes/+layout.svelte +++ b/packages/frontend/src/routes/+layout.svelte @@ -7,7 +7,7 @@ import Footer from "$lib/components/footer/footer.svelte"; import { Toaster } from "$lib/components/ui/sonner"; import Header from "$lib/components/header/header.svelte"; import AgeVerificationDialog from "$lib/components/age-verification-dialog/age-verification-dialog.svelte"; -import { env } from "$env/dynamic/public"; +import { PUBLIC_UMAMI_ID, PUBLIC_UMAMI_SCRIPT } from "$env/static/public"; onMount(async () => { await waitLocale(); @@ -17,11 +17,11 @@ let { children, data } = $props(); - {#if import.meta.env.PROD && env.PUBLIC_UMAMI_ID && env.PUBLIC_UMAMI_SCRIPT} + {#if import.meta.env.PROD && PUBLIC_UMAMI_ID && PUBLIC_UMAMI_SCRIPT} {/if}