valknar/roux
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix tab highlight: exact category URL match instead of substring

Browse Source 
/categories/dark-fantasy/ was also activating the Fantasy tab
because path.includes('fantasy') matched. Now compares the full
/categories/{slug}/ path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Sebastian Krüger
2026-05-18 17:33:42 +02:00
parent 073c4b804c
commit e8226b2e2f
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/js/app.js
+3 -2
View File
@@ -91,8 +91,9 @@
const path = location.pathname; const path = location.pathname;
tabs.forEach(btn => { tabs.forEach(btn => {
const cat = btn.dataset.cat; const cat = btn.dataset.cat;
const active = (cat === 'All' && (path === '/' || path.startsWith('/issue') || path === '/posts/')) const slug = cat.toLowerCase().replace(/\s+/g, '-').replace(/[^a-z0-9-]/g, '');
|| (cat !== 'All' && path.toLowerCase().includes(cat.toLowerCase().replace(/\s+/g, '-').replace(/[^a-z0-9-]/g, ''))); const active = (cat === 'All' && (path === '/' || path.startsWith('/issues') || path === '/posts/'))
|| (cat !== 'All' && path === `/categories/${slug}/`);
btn.setAttribute('aria-pressed', active ? 'true' : 'false'); btn.setAttribute('aria-pressed', active ? 'true' : 'false');
}); });
} }
static/js/app.js
+3 -2
View File
@@ -91,8 +91,9 @@
const path = location.pathname; const path = location.pathname;
tabs.forEach(btn => { tabs.forEach(btn => {
const cat = btn.dataset.cat; const cat = btn.dataset.cat;
const active = (cat === 'All' && (path === '/' || path.startsWith('/issue') || path === '/posts/')) const slug = cat.toLowerCase().replace(/\s+/g, '-').replace(/[^a-z0-9-]/g, '');
|| (cat !== 'All' && path.toLowerCase().includes(cat.toLowerCase().replace(/\s+/g, '-').replace(/[^a-z0-9-]/g, ''))); const active = (cat === 'All' && (path === '/' || path.startsWith('/issues') || path === '/posts/'))
|| (cat !== 'All' && path === `/categories/${slug}/`);
btn.setAttribute('aria-pressed', active ? 'true' : 'false'); btn.setAttribute('aria-pressed', active ? 'true' : 'false');
}); });
} }