Because of a quirk of how implementation tests work in Rust, we had a number of `#[allow(dead_code)]` annotations that were misleading because the functions _were_ being used, just not by all integration tests in a `tests/` folder, so when compiling the test that did not use the function, clippy would complain that it was unused. This fixes things by create a "test_support" crate under the `tests/` folder that is imported as a dev dependency for the respective crate.
177 lines
5.7 KiB
Rust
177 lines
5.7 KiB
Rust
#![cfg(unix)]
|
|
// Support code lives in the `mcp_test_support` crate under tests/common.
|
|
|
|
use std::path::Path;
|
|
|
|
use codex_core::exec::CODEX_SANDBOX_NETWORK_DISABLED_ENV_VAR;
|
|
use codex_mcp_server::CodexToolCallParam;
|
|
use mcp_types::JSONRPCResponse;
|
|
use mcp_types::RequestId;
|
|
use serde_json::json;
|
|
use tempfile::TempDir;
|
|
use tokio::time::timeout;
|
|
|
|
use mcp_test_support::McpProcess;
|
|
use mcp_test_support::create_mock_chat_completions_server;
|
|
use mcp_test_support::create_shell_sse_response;
|
|
|
|
const DEFAULT_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_shell_command_interruption() {
|
|
if std::env::var(CODEX_SANDBOX_NETWORK_DISABLED_ENV_VAR).is_ok() {
|
|
println!(
|
|
"Skipping test because it cannot execute when network is disabled in a Codex sandbox."
|
|
);
|
|
return;
|
|
}
|
|
|
|
if let Err(err) = shell_command_interruption().await {
|
|
panic!("failure: {err}");
|
|
}
|
|
}
|
|
|
|
async fn shell_command_interruption() -> anyhow::Result<()> {
|
|
// Use a cross-platform blocking command. On Windows plain `sleep` is not guaranteed to exist
|
|
// (MSYS/GNU coreutils may be absent) and the failure causes the tool call to finish immediately,
|
|
// which triggers a second model request before the test sends the explicit follow-up. That
|
|
// prematurely consumes the second mocked SSE response and leads to a third POST (panic: no response for 2).
|
|
// Powershell Start-Sleep is always available on Windows runners. On Unix we keep using `sleep`.
|
|
#[cfg(target_os = "windows")]
|
|
let shell_command = vec![
|
|
"powershell".to_string(),
|
|
"-Command".to_string(),
|
|
"Start-Sleep -Seconds 60".to_string(),
|
|
];
|
|
#[cfg(not(target_os = "windows"))]
|
|
let shell_command = vec!["sleep".to_string(), "60".to_string()];
|
|
let workdir_for_shell_function_call = TempDir::new()?;
|
|
|
|
// Create mock server with a single SSE response: the long sleep command
|
|
let server = create_mock_chat_completions_server(vec![
|
|
create_shell_sse_response(
|
|
shell_command.clone(),
|
|
Some(workdir_for_shell_function_call.path()),
|
|
Some(60_000), // 60 seconds timeout in ms
|
|
"call_sleep",
|
|
)?,
|
|
create_shell_sse_response(
|
|
shell_command.clone(),
|
|
Some(workdir_for_shell_function_call.path()),
|
|
Some(60_000), // 60 seconds timeout in ms
|
|
"call_sleep",
|
|
)?,
|
|
])
|
|
.await;
|
|
|
|
// Create Codex configuration
|
|
let codex_home = TempDir::new()?;
|
|
create_config_toml(codex_home.path(), server.uri())?;
|
|
let mut mcp_process = McpProcess::new(codex_home.path()).await?;
|
|
timeout(DEFAULT_READ_TIMEOUT, mcp_process.initialize()).await??;
|
|
|
|
// Send codex tool call that triggers "sleep 60"
|
|
let codex_request_id = mcp_process
|
|
.send_codex_tool_call(CodexToolCallParam {
|
|
cwd: None,
|
|
prompt: "First Run: run `sleep 60`".to_string(),
|
|
model: None,
|
|
profile: None,
|
|
approval_policy: None,
|
|
sandbox: None,
|
|
config: None,
|
|
base_instructions: None,
|
|
})
|
|
.await?;
|
|
|
|
let session_id = mcp_process
|
|
.read_stream_until_configured_response_message()
|
|
.await?;
|
|
|
|
// Give the command a moment to start
|
|
tokio::time::sleep(std::time::Duration::from_secs(1)).await;
|
|
|
|
// Send interrupt notification
|
|
mcp_process
|
|
.send_notification(
|
|
"notifications/cancelled",
|
|
Some(json!({ "requestId": codex_request_id })),
|
|
)
|
|
.await?;
|
|
|
|
// Expect Codex to return an error or interruption response
|
|
let codex_response: JSONRPCResponse = timeout(
|
|
DEFAULT_READ_TIMEOUT,
|
|
mcp_process.read_stream_until_response_message(RequestId::Integer(codex_request_id)),
|
|
)
|
|
.await??;
|
|
|
|
assert!(
|
|
codex_response
|
|
.result
|
|
.as_object()
|
|
.map(|o| o.contains_key("error"))
|
|
.unwrap_or(false),
|
|
"Expected an interruption or error result, got: {codex_response:?}"
|
|
);
|
|
|
|
let codex_reply_request_id = mcp_process
|
|
.send_codex_reply_tool_call(&session_id, "Second Run: run `sleep 60`")
|
|
.await?;
|
|
|
|
// Give the command a moment to start
|
|
tokio::time::sleep(std::time::Duration::from_secs(1)).await;
|
|
|
|
// Send interrupt notification
|
|
mcp_process
|
|
.send_notification(
|
|
"notifications/cancelled",
|
|
Some(json!({ "requestId": codex_reply_request_id })),
|
|
)
|
|
.await?;
|
|
|
|
// Expect Codex to return an error or interruption response
|
|
let codex_response: JSONRPCResponse = timeout(
|
|
DEFAULT_READ_TIMEOUT,
|
|
mcp_process.read_stream_until_response_message(RequestId::Integer(codex_reply_request_id)),
|
|
)
|
|
.await??;
|
|
|
|
assert!(
|
|
codex_response
|
|
.result
|
|
.as_object()
|
|
.map(|o| o.contains_key("error"))
|
|
.unwrap_or(false),
|
|
"Expected an interruption or error result, got: {codex_response:?}"
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Helpers
|
|
// ---------------------------------------------------------------------------
|
|
|
|
fn create_config_toml(codex_home: &Path, server_uri: String) -> std::io::Result<()> {
|
|
let config_toml = codex_home.join("config.toml");
|
|
std::fs::write(
|
|
config_toml,
|
|
format!(
|
|
r#"
|
|
model = "mock-model"
|
|
approval_policy = "never"
|
|
sandbox_mode = "danger-full-access"
|
|
|
|
model_provider = "mock_provider"
|
|
|
|
[model_providers.mock_provider]
|
|
name = "Mock provider for test"
|
|
base_url = "{server_uri}/v1"
|
|
wire_api = "chat"
|
|
request_max_retries = 0
|
|
stream_max_retries = 0
|
|
"#
|
|
),
|
|
)
|
|
}
|