This PR: * Added the clippy.toml to configure allowable expect / unwrap usage in tests * Removed as many expect/allow lines as possible from tests * moved a bunch of allows to expects where possible Note: in integration tests, non `#[test]` helper functions are not covered by this so we had to leave a few lingering `expect(expect_used` checks around
51 lines
1.6 KiB
Rust
51 lines
1.6 KiB
Rust
use codex_execpolicy::ArgType;
|
|
use codex_execpolicy::Error;
|
|
use codex_execpolicy::ExecCall;
|
|
use codex_execpolicy::MatchedArg;
|
|
use codex_execpolicy::MatchedExec;
|
|
use codex_execpolicy::PolicyParser;
|
|
use codex_execpolicy::Result;
|
|
use codex_execpolicy::ValidExec;
|
|
|
|
extern crate codex_execpolicy;
|
|
|
|
#[test]
|
|
fn test_invalid_subcommand() -> Result<()> {
|
|
let unparsed_policy = r#"
|
|
define_program(
|
|
program="fake_executable",
|
|
args=["subcommand", "sub-subcommand"],
|
|
)
|
|
"#;
|
|
let parser = PolicyParser::new("test_invalid_subcommand", unparsed_policy);
|
|
let policy = parser.parse().expect("failed to parse policy");
|
|
let valid_call = ExecCall::new("fake_executable", &["subcommand", "sub-subcommand"]);
|
|
assert_eq!(
|
|
Ok(MatchedExec::Match {
|
|
exec: ValidExec::new(
|
|
"fake_executable",
|
|
vec![
|
|
MatchedArg::new(0, ArgType::Literal("subcommand".to_string()), "subcommand")?,
|
|
MatchedArg::new(
|
|
1,
|
|
ArgType::Literal("sub-subcommand".to_string()),
|
|
"sub-subcommand"
|
|
)?,
|
|
],
|
|
&[]
|
|
)
|
|
}),
|
|
policy.check(&valid_call)
|
|
);
|
|
|
|
let invalid_call = ExecCall::new("fake_executable", &["subcommand", "not-a-real-subcommand"]);
|
|
assert_eq!(
|
|
Err(Error::LiteralValueDidNotMatch {
|
|
expected: "sub-subcommand".to_string(),
|
|
actual: "not-a-real-subcommand".to_string()
|
|
}),
|
|
policy.check(&invalid_call)
|
|
);
|
|
Ok(())
|
|
}
|