We had this annotation everywhere in app-server APIs which made it so that fields get serialized as `field?: T`, meaning if the field as `None` we would omit the field in the payload. Removing this annotation changes it so that we return `field: T | null` instead, which makes codex app-server's API more aligned with the convention of public OpenAI APIs like Responses. Separately, remove the `#[ts(optional_fields = nullable)]` annotations that were recently added which made all the TS types become `field?: T | null` which is not great since clients need to handle undefined and null. I think generally it'll be best to have optional types be either: - `field: T | null` (preferred, aligned with public OpenAI APIs) - `field?: T` where we have to, such as types generated from the MCP schema: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-06-18/schema.ts (see changes to `mcp-types/`) I updated @etraut-openai's unit test to check that all generated TS types are one or the other, not both (so will error if we have a type that has `field?: T | null`). I don't think there's currently a good use case for that - but we can always revisit.
738 lines
26 KiB
Rust
738 lines
26 KiB
Rust
use crate::ClientNotification;
|
|
use crate::ClientRequest;
|
|
use crate::ServerNotification;
|
|
use crate::ServerRequest;
|
|
use crate::export_client_response_schemas;
|
|
use crate::export_client_responses;
|
|
use crate::export_server_response_schemas;
|
|
use crate::export_server_responses;
|
|
use anyhow::Context;
|
|
use anyhow::Result;
|
|
use anyhow::anyhow;
|
|
use schemars::JsonSchema;
|
|
use schemars::schema::RootSchema;
|
|
use schemars::schema_for;
|
|
use serde::Serialize;
|
|
use serde_json::Map;
|
|
use serde_json::Value;
|
|
use std::collections::BTreeMap;
|
|
use std::collections::HashSet;
|
|
use std::ffi::OsStr;
|
|
use std::fs;
|
|
use std::io::Read;
|
|
use std::io::Write;
|
|
use std::path::Path;
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
use ts_rs::TS;
|
|
|
|
const HEADER: &str = "// GENERATED CODE! DO NOT MODIFY BY HAND!\n\n";
|
|
|
|
macro_rules! for_each_schema_type {
|
|
($macro:ident) => {
|
|
$macro!(crate::RequestId);
|
|
$macro!(crate::JSONRPCMessage);
|
|
$macro!(crate::JSONRPCRequest);
|
|
$macro!(crate::JSONRPCNotification);
|
|
$macro!(crate::JSONRPCResponse);
|
|
$macro!(crate::JSONRPCError);
|
|
$macro!(crate::JSONRPCErrorError);
|
|
$macro!(crate::AddConversationListenerParams);
|
|
$macro!(crate::AddConversationSubscriptionResponse);
|
|
$macro!(crate::ApplyPatchApprovalParams);
|
|
$macro!(crate::ApplyPatchApprovalResponse);
|
|
$macro!(crate::ArchiveConversationParams);
|
|
$macro!(crate::ArchiveConversationResponse);
|
|
$macro!(crate::AuthMode);
|
|
$macro!(crate::AuthStatusChangeNotification);
|
|
$macro!(crate::CancelLoginChatGptParams);
|
|
$macro!(crate::CancelLoginChatGptResponse);
|
|
$macro!(crate::ClientInfo);
|
|
$macro!(crate::ClientNotification);
|
|
$macro!(crate::ClientRequest);
|
|
$macro!(crate::ConversationSummary);
|
|
$macro!(crate::ExecCommandApprovalParams);
|
|
$macro!(crate::ExecCommandApprovalResponse);
|
|
$macro!(crate::ExecOneOffCommandParams);
|
|
$macro!(crate::ExecOneOffCommandResponse);
|
|
$macro!(crate::FuzzyFileSearchParams);
|
|
$macro!(crate::FuzzyFileSearchResponse);
|
|
$macro!(crate::FuzzyFileSearchResult);
|
|
$macro!(crate::GetAuthStatusParams);
|
|
$macro!(crate::GetAuthStatusResponse);
|
|
$macro!(crate::GetUserAgentResponse);
|
|
$macro!(crate::GetUserSavedConfigResponse);
|
|
$macro!(crate::GitDiffToRemoteParams);
|
|
$macro!(crate::GitDiffToRemoteResponse);
|
|
$macro!(crate::GitSha);
|
|
$macro!(crate::InitializeParams);
|
|
$macro!(crate::InitializeResponse);
|
|
$macro!(crate::InputItem);
|
|
$macro!(crate::InterruptConversationParams);
|
|
$macro!(crate::InterruptConversationResponse);
|
|
$macro!(crate::ListConversationsParams);
|
|
$macro!(crate::ListConversationsResponse);
|
|
$macro!(crate::LoginApiKeyParams);
|
|
$macro!(crate::LoginApiKeyResponse);
|
|
$macro!(crate::LoginChatGptCompleteNotification);
|
|
$macro!(crate::LoginChatGptResponse);
|
|
$macro!(crate::LogoutChatGptParams);
|
|
$macro!(crate::LogoutChatGptResponse);
|
|
$macro!(crate::NewConversationParams);
|
|
$macro!(crate::NewConversationResponse);
|
|
$macro!(crate::Profile);
|
|
$macro!(crate::RemoveConversationListenerParams);
|
|
$macro!(crate::RemoveConversationSubscriptionResponse);
|
|
$macro!(crate::ResumeConversationParams);
|
|
$macro!(crate::ResumeConversationResponse);
|
|
$macro!(crate::SandboxSettings);
|
|
$macro!(crate::SendUserMessageParams);
|
|
$macro!(crate::SendUserMessageResponse);
|
|
$macro!(crate::SendUserTurnParams);
|
|
$macro!(crate::SendUserTurnResponse);
|
|
$macro!(crate::ServerNotification);
|
|
$macro!(crate::ServerRequest);
|
|
$macro!(crate::SessionConfiguredNotification);
|
|
$macro!(crate::SetDefaultModelParams);
|
|
$macro!(crate::SetDefaultModelResponse);
|
|
$macro!(crate::Tools);
|
|
$macro!(crate::UserInfoResponse);
|
|
$macro!(crate::UserSavedConfig);
|
|
$macro!(codex_protocol::protocol::EventMsg);
|
|
$macro!(codex_protocol::protocol::FileChange);
|
|
$macro!(codex_protocol::parse_command::ParsedCommand);
|
|
$macro!(codex_protocol::protocol::SandboxPolicy);
|
|
};
|
|
}
|
|
|
|
pub fn generate_types(out_dir: &Path, prettier: Option<&Path>) -> Result<()> {
|
|
generate_ts(out_dir, prettier)?;
|
|
generate_json(out_dir)?;
|
|
Ok(())
|
|
}
|
|
|
|
pub fn generate_ts(out_dir: &Path, prettier: Option<&Path>) -> Result<()> {
|
|
ensure_dir(out_dir)?;
|
|
|
|
ClientRequest::export_all_to(out_dir)?;
|
|
export_client_responses(out_dir)?;
|
|
ClientNotification::export_all_to(out_dir)?;
|
|
|
|
ServerRequest::export_all_to(out_dir)?;
|
|
export_server_responses(out_dir)?;
|
|
ServerNotification::export_all_to(out_dir)?;
|
|
|
|
generate_index_ts(out_dir)?;
|
|
|
|
let ts_files = ts_files_in(out_dir)?;
|
|
for file in &ts_files {
|
|
prepend_header_if_missing(file)?;
|
|
}
|
|
|
|
if let Some(prettier_bin) = prettier
|
|
&& !ts_files.is_empty()
|
|
{
|
|
let status = Command::new(prettier_bin)
|
|
.arg("--write")
|
|
.args(ts_files.iter().map(|p| p.as_os_str()))
|
|
.status()
|
|
.with_context(|| format!("Failed to invoke Prettier at {}", prettier_bin.display()))?;
|
|
if !status.success() {
|
|
return Err(anyhow!("Prettier failed with status {status}"));
|
|
}
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
pub fn generate_json(out_dir: &Path) -> Result<()> {
|
|
ensure_dir(out_dir)?;
|
|
let mut bundle: BTreeMap<String, RootSchema> = BTreeMap::new();
|
|
|
|
macro_rules! add_schema {
|
|
($ty:path) => {{
|
|
let name = type_basename(stringify!($ty));
|
|
let schema = write_json_schema_with_return::<$ty>(out_dir, &name)?;
|
|
bundle.insert(name, schema);
|
|
}};
|
|
}
|
|
|
|
for_each_schema_type!(add_schema);
|
|
|
|
export_client_response_schemas(out_dir)?;
|
|
export_server_response_schemas(out_dir)?;
|
|
|
|
let mut definitions = Map::new();
|
|
|
|
const SPECIAL_DEFINITIONS: &[&str] = &[
|
|
"ClientNotification",
|
|
"ClientRequest",
|
|
"EventMsg",
|
|
"FileChange",
|
|
"InputItem",
|
|
"ParsedCommand",
|
|
"SandboxPolicy",
|
|
"ServerNotification",
|
|
"ServerRequest",
|
|
];
|
|
|
|
for (name, schema) in bundle {
|
|
let mut schema_value = serde_json::to_value(schema)?;
|
|
annotate_schema(&mut schema_value, Some(name.as_str()));
|
|
|
|
if let Value::Object(ref mut obj) = schema_value
|
|
&& let Some(defs) = obj.remove("definitions")
|
|
&& let Value::Object(defs_obj) = defs
|
|
{
|
|
for (def_name, mut def_schema) in defs_obj {
|
|
if !SPECIAL_DEFINITIONS.contains(&def_name.as_str()) {
|
|
annotate_schema(&mut def_schema, Some(def_name.as_str()));
|
|
definitions.insert(def_name, def_schema);
|
|
}
|
|
}
|
|
}
|
|
definitions.insert(name, schema_value);
|
|
}
|
|
|
|
let mut root = Map::new();
|
|
root.insert(
|
|
"$schema".to_string(),
|
|
Value::String("http://json-schema.org/draft-07/schema#".into()),
|
|
);
|
|
root.insert(
|
|
"title".to_string(),
|
|
Value::String("CodexAppServerProtocol".into()),
|
|
);
|
|
root.insert("type".to_string(), Value::String("object".into()));
|
|
root.insert("definitions".to_string(), Value::Object(definitions));
|
|
|
|
write_pretty_json(
|
|
out_dir.join("codex_app_server_protocol.schemas.json"),
|
|
&Value::Object(root),
|
|
)?;
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn write_json_schema_with_return<T>(out_dir: &Path, name: &str) -> Result<RootSchema>
|
|
where
|
|
T: JsonSchema,
|
|
{
|
|
let file_stem = name.trim();
|
|
let schema = schema_for!(T);
|
|
let mut schema_value = serde_json::to_value(schema)?;
|
|
annotate_schema(&mut schema_value, Some(file_stem));
|
|
write_pretty_json(out_dir.join(format!("{file_stem}.json")), &schema_value)
|
|
.with_context(|| format!("Failed to write JSON schema for {file_stem}"))?;
|
|
let annotated_schema = serde_json::from_value(schema_value)?;
|
|
Ok(annotated_schema)
|
|
}
|
|
|
|
pub(crate) fn write_json_schema<T>(out_dir: &Path, name: &str) -> Result<()>
|
|
where
|
|
T: JsonSchema,
|
|
{
|
|
write_json_schema_with_return::<T>(out_dir, name).map(|_| ())
|
|
}
|
|
|
|
fn write_pretty_json(path: PathBuf, value: &impl Serialize) -> Result<()> {
|
|
let json = serde_json::to_vec_pretty(value)
|
|
.with_context(|| format!("Failed to serialize JSON schema to {}", path.display()))?;
|
|
fs::write(&path, json).with_context(|| format!("Failed to write {}", path.display()))?;
|
|
Ok(())
|
|
}
|
|
fn type_basename(type_path: &str) -> String {
|
|
type_path
|
|
.rsplit_once("::")
|
|
.map(|(_, name)| name)
|
|
.unwrap_or(type_path)
|
|
.trim()
|
|
.to_string()
|
|
}
|
|
|
|
fn variant_definition_name(base: &str, variant: &Value) -> Option<String> {
|
|
if let Some(props) = variant.get("properties").and_then(Value::as_object) {
|
|
if let Some(method_literal) = literal_from_property(props, "method") {
|
|
let pascal = to_pascal_case(method_literal);
|
|
return Some(match base {
|
|
"ClientRequest" | "ServerRequest" => format!("{pascal}Request"),
|
|
"ClientNotification" | "ServerNotification" => format!("{pascal}Notification"),
|
|
_ => format!("{pascal}{base}"),
|
|
});
|
|
}
|
|
|
|
if let Some(type_literal) = literal_from_property(props, "type") {
|
|
let pascal = to_pascal_case(type_literal);
|
|
return Some(match base {
|
|
"EventMsg" => format!("{pascal}EventMsg"),
|
|
_ => format!("{pascal}{base}"),
|
|
});
|
|
}
|
|
|
|
if let Some(mode_literal) = literal_from_property(props, "mode") {
|
|
let pascal = to_pascal_case(mode_literal);
|
|
return Some(match base {
|
|
"SandboxPolicy" => format!("{pascal}SandboxPolicy"),
|
|
_ => format!("{pascal}{base}"),
|
|
});
|
|
}
|
|
|
|
if props.len() == 1
|
|
&& let Some(key) = props.keys().next()
|
|
{
|
|
let pascal = to_pascal_case(key);
|
|
return Some(format!("{pascal}{base}"));
|
|
}
|
|
}
|
|
|
|
if let Some(required) = variant.get("required").and_then(Value::as_array)
|
|
&& required.len() == 1
|
|
&& let Some(key) = required[0].as_str()
|
|
{
|
|
let pascal = to_pascal_case(key);
|
|
return Some(format!("{pascal}{base}"));
|
|
}
|
|
|
|
None
|
|
}
|
|
|
|
fn literal_from_property<'a>(props: &'a Map<String, Value>, key: &str) -> Option<&'a str> {
|
|
props.get(key).and_then(string_literal)
|
|
}
|
|
|
|
fn string_literal(value: &Value) -> Option<&str> {
|
|
value.get("const").and_then(Value::as_str).or_else(|| {
|
|
value
|
|
.get("enum")
|
|
.and_then(Value::as_array)
|
|
.and_then(|arr| arr.first())
|
|
.and_then(Value::as_str)
|
|
})
|
|
}
|
|
|
|
fn annotate_schema(value: &mut Value, base: Option<&str>) {
|
|
match value {
|
|
Value::Object(map) => annotate_object(map, base),
|
|
Value::Array(items) => {
|
|
for item in items {
|
|
annotate_schema(item, base);
|
|
}
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
|
|
fn annotate_object(map: &mut Map<String, Value>, base: Option<&str>) {
|
|
let owner = map.get("title").and_then(Value::as_str).map(str::to_owned);
|
|
if let Some(owner) = owner.as_deref()
|
|
&& let Some(Value::Object(props)) = map.get_mut("properties")
|
|
{
|
|
set_discriminator_titles(props, owner);
|
|
}
|
|
|
|
if let Some(Value::Array(variants)) = map.get_mut("oneOf") {
|
|
annotate_variant_list(variants, base);
|
|
}
|
|
if let Some(Value::Array(variants)) = map.get_mut("anyOf") {
|
|
annotate_variant_list(variants, base);
|
|
}
|
|
|
|
if let Some(Value::Object(defs)) = map.get_mut("definitions") {
|
|
for (name, schema) in defs.iter_mut() {
|
|
annotate_schema(schema, Some(name.as_str()));
|
|
}
|
|
}
|
|
|
|
if let Some(Value::Object(defs)) = map.get_mut("$defs") {
|
|
for (name, schema) in defs.iter_mut() {
|
|
annotate_schema(schema, Some(name.as_str()));
|
|
}
|
|
}
|
|
|
|
if let Some(Value::Object(props)) = map.get_mut("properties") {
|
|
for value in props.values_mut() {
|
|
annotate_schema(value, base);
|
|
}
|
|
}
|
|
|
|
if let Some(items) = map.get_mut("items") {
|
|
annotate_schema(items, base);
|
|
}
|
|
|
|
if let Some(additional) = map.get_mut("additionalProperties") {
|
|
annotate_schema(additional, base);
|
|
}
|
|
|
|
for (key, child) in map.iter_mut() {
|
|
match key.as_str() {
|
|
"oneOf"
|
|
| "anyOf"
|
|
| "definitions"
|
|
| "$defs"
|
|
| "properties"
|
|
| "items"
|
|
| "additionalProperties" => {}
|
|
_ => annotate_schema(child, base),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn annotate_variant_list(variants: &mut [Value], base: Option<&str>) {
|
|
let mut seen = HashSet::new();
|
|
|
|
for variant in variants.iter() {
|
|
if let Some(name) = variant_title(variant) {
|
|
seen.insert(name.to_owned());
|
|
}
|
|
}
|
|
|
|
for variant in variants.iter_mut() {
|
|
let mut variant_name = variant_title(variant).map(str::to_owned);
|
|
|
|
if variant_name.is_none()
|
|
&& let Some(base_name) = base
|
|
&& let Some(name) = variant_definition_name(base_name, variant)
|
|
{
|
|
let mut candidate = name.clone();
|
|
let mut index = 2;
|
|
while seen.contains(&candidate) {
|
|
candidate = format!("{name}{index}");
|
|
index += 1;
|
|
}
|
|
if let Some(obj) = variant.as_object_mut() {
|
|
obj.insert("title".into(), Value::String(candidate.clone()));
|
|
}
|
|
seen.insert(candidate.clone());
|
|
variant_name = Some(candidate);
|
|
}
|
|
|
|
if let Some(name) = variant_name.as_deref()
|
|
&& let Some(obj) = variant.as_object_mut()
|
|
&& let Some(Value::Object(props)) = obj.get_mut("properties")
|
|
{
|
|
set_discriminator_titles(props, name);
|
|
}
|
|
|
|
annotate_schema(variant, base);
|
|
}
|
|
}
|
|
|
|
const DISCRIMINATOR_KEYS: &[&str] = &["type", "method", "mode", "status", "role", "reason"];
|
|
|
|
fn set_discriminator_titles(props: &mut Map<String, Value>, owner: &str) {
|
|
for key in DISCRIMINATOR_KEYS {
|
|
if let Some(prop_schema) = props.get_mut(*key)
|
|
&& string_literal(prop_schema).is_some()
|
|
&& let Value::Object(prop_obj) = prop_schema
|
|
{
|
|
if prop_obj.contains_key("title") {
|
|
continue;
|
|
}
|
|
let suffix = to_pascal_case(key);
|
|
prop_obj.insert("title".into(), Value::String(format!("{owner}{suffix}")));
|
|
}
|
|
}
|
|
}
|
|
|
|
fn variant_title(value: &Value) -> Option<&str> {
|
|
value
|
|
.as_object()
|
|
.and_then(|obj| obj.get("title"))
|
|
.and_then(Value::as_str)
|
|
}
|
|
|
|
fn to_pascal_case(input: &str) -> String {
|
|
let mut result = String::new();
|
|
let mut capitalize_next = true;
|
|
|
|
for c in input.chars() {
|
|
if c == '_' || c == '-' {
|
|
capitalize_next = true;
|
|
continue;
|
|
}
|
|
|
|
if capitalize_next {
|
|
result.extend(c.to_uppercase());
|
|
capitalize_next = false;
|
|
} else {
|
|
result.push(c);
|
|
}
|
|
}
|
|
|
|
result
|
|
}
|
|
|
|
fn ensure_dir(dir: &Path) -> Result<()> {
|
|
fs::create_dir_all(dir)
|
|
.with_context(|| format!("Failed to create output directory {}", dir.display()))
|
|
}
|
|
|
|
fn prepend_header_if_missing(path: &Path) -> Result<()> {
|
|
let mut content = String::new();
|
|
{
|
|
let mut f = fs::File::open(path)
|
|
.with_context(|| format!("Failed to open {} for reading", path.display()))?;
|
|
f.read_to_string(&mut content)
|
|
.with_context(|| format!("Failed to read {}", path.display()))?;
|
|
}
|
|
|
|
if content.starts_with(HEADER) {
|
|
return Ok(());
|
|
}
|
|
|
|
let mut f = fs::File::create(path)
|
|
.with_context(|| format!("Failed to open {} for writing", path.display()))?;
|
|
f.write_all(HEADER.as_bytes())
|
|
.with_context(|| format!("Failed to write header to {}", path.display()))?;
|
|
f.write_all(content.as_bytes())
|
|
.with_context(|| format!("Failed to write content to {}", path.display()))?;
|
|
Ok(())
|
|
}
|
|
|
|
fn ts_files_in(dir: &Path) -> Result<Vec<PathBuf>> {
|
|
let mut files = Vec::new();
|
|
for entry in
|
|
fs::read_dir(dir).with_context(|| format!("Failed to read dir {}", dir.display()))?
|
|
{
|
|
let entry = entry?;
|
|
let path = entry.path();
|
|
if path.is_file() && path.extension() == Some(OsStr::new("ts")) {
|
|
files.push(path);
|
|
}
|
|
}
|
|
files.sort();
|
|
Ok(files)
|
|
}
|
|
|
|
fn generate_index_ts(out_dir: &Path) -> Result<PathBuf> {
|
|
let mut entries: Vec<String> = Vec::new();
|
|
let mut stems: Vec<String> = ts_files_in(out_dir)?
|
|
.into_iter()
|
|
.filter_map(|p| {
|
|
let stem = p.file_stem()?.to_string_lossy().into_owned();
|
|
if stem == "index" { None } else { Some(stem) }
|
|
})
|
|
.collect();
|
|
stems.sort();
|
|
stems.dedup();
|
|
|
|
for name in stems {
|
|
entries.push(format!("export type {{ {name} }} from \"./{name}\";\n"));
|
|
}
|
|
|
|
let mut content =
|
|
String::with_capacity(HEADER.len() + entries.iter().map(String::len).sum::<usize>());
|
|
content.push_str(HEADER);
|
|
for line in &entries {
|
|
content.push_str(line);
|
|
}
|
|
|
|
let index_path = out_dir.join("index.ts");
|
|
let mut f = fs::File::create(&index_path)
|
|
.with_context(|| format!("Failed to create {}", index_path.display()))?;
|
|
f.write_all(content.as_bytes())
|
|
.with_context(|| format!("Failed to write {}", index_path.display()))?;
|
|
Ok(index_path)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use anyhow::Result;
|
|
use std::collections::BTreeSet;
|
|
use std::fs;
|
|
use std::path::PathBuf;
|
|
use uuid::Uuid;
|
|
|
|
#[test]
|
|
fn generated_ts_has_no_optional_nullable_fields() -> Result<()> {
|
|
let output_dir = std::env::temp_dir().join(format!("codex_ts_types_{}", Uuid::now_v7()));
|
|
fs::create_dir(&output_dir)?;
|
|
|
|
struct TempDirGuard(PathBuf);
|
|
|
|
impl Drop for TempDirGuard {
|
|
fn drop(&mut self) {
|
|
let _ = fs::remove_dir_all(&self.0);
|
|
}
|
|
}
|
|
|
|
let _guard = TempDirGuard(output_dir.clone());
|
|
|
|
generate_ts(&output_dir, None)?;
|
|
|
|
let mut undefined_offenders = Vec::new();
|
|
let mut optional_nullable_offenders = BTreeSet::new();
|
|
let mut stack = vec![output_dir];
|
|
while let Some(dir) = stack.pop() {
|
|
for entry in fs::read_dir(&dir)? {
|
|
let entry = entry?;
|
|
let path = entry.path();
|
|
if path.is_dir() {
|
|
stack.push(path);
|
|
continue;
|
|
}
|
|
|
|
if matches!(path.extension().and_then(|ext| ext.to_str()), Some("ts")) {
|
|
let contents = fs::read_to_string(&path)?;
|
|
if contents.contains("| undefined") {
|
|
undefined_offenders.push(path.clone());
|
|
}
|
|
|
|
const SKIP_PREFIXES: &[&str] = &[
|
|
"const ",
|
|
"let ",
|
|
"var ",
|
|
"export const ",
|
|
"export let ",
|
|
"export var ",
|
|
];
|
|
|
|
let mut search_start = 0;
|
|
while let Some(idx) = contents[search_start..].find("| null") {
|
|
let abs_idx = search_start + idx;
|
|
// Find the property-colon for this field by scanning forward
|
|
// from the start of the segment and ignoring nested braces,
|
|
// brackets, and parens. This avoids colons inside nested
|
|
// type literals like `{ [k in string]?: string }`.
|
|
|
|
let line_start_idx =
|
|
contents[..abs_idx].rfind('\n').map(|i| i + 1).unwrap_or(0);
|
|
|
|
let mut segment_start_idx = line_start_idx;
|
|
if let Some(rel_idx) = contents[line_start_idx..abs_idx].rfind(',') {
|
|
segment_start_idx = segment_start_idx.max(line_start_idx + rel_idx + 1);
|
|
}
|
|
if let Some(rel_idx) = contents[line_start_idx..abs_idx].rfind('{') {
|
|
segment_start_idx = segment_start_idx.max(line_start_idx + rel_idx + 1);
|
|
}
|
|
if let Some(rel_idx) = contents[line_start_idx..abs_idx].rfind('}') {
|
|
segment_start_idx = segment_start_idx.max(line_start_idx + rel_idx + 1);
|
|
}
|
|
|
|
// Scan forward for the colon that separates the field name from its type.
|
|
let mut level_brace = 0_i32;
|
|
let mut level_brack = 0_i32;
|
|
let mut level_paren = 0_i32;
|
|
let mut in_single = false;
|
|
let mut in_double = false;
|
|
let mut escape = false;
|
|
let mut prop_colon_idx = None;
|
|
for (i, ch) in contents[segment_start_idx..abs_idx].char_indices() {
|
|
let idx_abs = segment_start_idx + i;
|
|
if escape {
|
|
escape = false;
|
|
continue;
|
|
}
|
|
match ch {
|
|
'\\' => {
|
|
// Only treat as escape when inside a string.
|
|
if in_single || in_double {
|
|
escape = true;
|
|
}
|
|
}
|
|
'\'' => {
|
|
if !in_double {
|
|
in_single = !in_single;
|
|
}
|
|
}
|
|
'"' => {
|
|
if !in_single {
|
|
in_double = !in_double;
|
|
}
|
|
}
|
|
'{' if !in_single && !in_double => level_brace += 1,
|
|
'}' if !in_single && !in_double => level_brace -= 1,
|
|
'[' if !in_single && !in_double => level_brack += 1,
|
|
']' if !in_single && !in_double => level_brack -= 1,
|
|
'(' if !in_single && !in_double => level_paren += 1,
|
|
')' if !in_single && !in_double => level_paren -= 1,
|
|
':' if !in_single
|
|
&& !in_double
|
|
&& level_brace == 0
|
|
&& level_brack == 0
|
|
&& level_paren == 0 =>
|
|
{
|
|
prop_colon_idx = Some(idx_abs);
|
|
break;
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
|
|
let Some(colon_idx) = prop_colon_idx else {
|
|
search_start = abs_idx + 5;
|
|
continue;
|
|
};
|
|
|
|
let mut field_prefix = contents[segment_start_idx..colon_idx].trim();
|
|
if field_prefix.is_empty() {
|
|
search_start = abs_idx + 5;
|
|
continue;
|
|
}
|
|
|
|
if let Some(comment_idx) = field_prefix.rfind("*/") {
|
|
field_prefix = field_prefix[comment_idx + 2..].trim_start();
|
|
}
|
|
|
|
if field_prefix.is_empty() {
|
|
search_start = abs_idx + 5;
|
|
continue;
|
|
}
|
|
|
|
if SKIP_PREFIXES
|
|
.iter()
|
|
.any(|prefix| field_prefix.starts_with(prefix))
|
|
{
|
|
search_start = abs_idx + 5;
|
|
continue;
|
|
}
|
|
|
|
if field_prefix.contains('(') {
|
|
search_start = abs_idx + 5;
|
|
continue;
|
|
}
|
|
|
|
// If the last non-whitespace before ':' is '?', then this is an
|
|
// optional field with a nullable type (i.e., "?: T | null"),
|
|
// which we explicitly disallow.
|
|
if field_prefix.chars().rev().find(|c| !c.is_whitespace()) == Some('?') {
|
|
let line_number =
|
|
contents[..abs_idx].chars().filter(|c| *c == '\n').count() + 1;
|
|
let offending_line_end = contents[line_start_idx..]
|
|
.find('\n')
|
|
.map(|i| line_start_idx + i)
|
|
.unwrap_or(contents.len());
|
|
let offending_snippet =
|
|
contents[line_start_idx..offending_line_end].trim();
|
|
|
|
optional_nullable_offenders.insert(format!(
|
|
"{}:{}: {offending_snippet}",
|
|
path.display(),
|
|
line_number
|
|
));
|
|
}
|
|
|
|
search_start = abs_idx + 5;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
assert!(
|
|
undefined_offenders.is_empty(),
|
|
"Generated TypeScript still includes unions with `undefined` in {undefined_offenders:?}"
|
|
);
|
|
|
|
// If this assertion fails, it means a field was generated as
|
|
// "?: T | null" — i.e., both optional (undefined) and nullable (null).
|
|
// We only want either "?: T" or ": T | null".
|
|
assert!(
|
|
optional_nullable_offenders.is_empty(),
|
|
"Generated TypeScript has optional fields with nullable types (disallowed '?: T | null'), add #[ts(optional)] to fix:\n{optional_nullable_offenders:?}"
|
|
);
|
|
|
|
Ok(())
|
|
}
|
|
}
|