https://github.com/openai/codex/pull/855 added the clippy warning to disallow `unwrap()`, but apparently we were not verifying that tests were "clippy clean" in CI, so I ended up with a lot of local errors in VS Code. This turns on the check in CI and fixes the offenders.
42 lines
1.4 KiB
Rust
42 lines
1.4 KiB
Rust
use serde::Serialize;
|
|
|
|
/// User can configure a program that will receive notifications. Each
|
|
/// notification is serialized as JSON and passed as an argument to the
|
|
/// program.
|
|
#[derive(Debug, Clone, PartialEq, Serialize)]
|
|
#[serde(tag = "type", rename_all = "kebab-case")]
|
|
pub(crate) enum UserNotification {
|
|
#[serde(rename_all = "kebab-case")]
|
|
AgentTurnComplete {
|
|
turn_id: String,
|
|
|
|
/// Messages that the user sent to the agent to initiate the turn.
|
|
input_messages: Vec<String>,
|
|
|
|
/// The last message sent by the assistant in the turn.
|
|
last_assistant_message: Option<String>,
|
|
},
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
#![allow(clippy::unwrap_used)]
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_user_notification() {
|
|
let notification = UserNotification::AgentTurnComplete {
|
|
turn_id: "12345".to_string(),
|
|
input_messages: vec!["Rename `foo` to `bar` and update the callsites.".to_string()],
|
|
last_assistant_message: Some(
|
|
"Rename complete and verified `cargo build` succeeds.".to_string(),
|
|
),
|
|
};
|
|
let serialized = serde_json::to_string(¬ification).unwrap();
|
|
assert_eq!(
|
|
serialized,
|
|
r#"{"type":"agent-turn-complete","turn-id":"12345","input-messages":["Rename `foo` to `bar` and update the callsites."],"last-assistant-message":"Rename complete and verified `cargo build` succeeds."}"#
|
|
);
|
|
}
|
|
}
|