feat: tab completions for file paths (#279)
Made a PR as was requested in the #113
This commit is contained in:
73
codex-cli/tests/file-system-suggestions.test.ts
Normal file
73
codex-cli/tests/file-system-suggestions.test.ts
Normal file
@@ -0,0 +1,73 @@
|
||||
import { describe, it, expect, vi, beforeEach } from "vitest";
|
||||
import fs from "fs";
|
||||
import os from "os";
|
||||
import path from "path";
|
||||
import { getFileSystemSuggestions } from "../src/utils/file-system-suggestions";
|
||||
|
||||
vi.mock("fs");
|
||||
vi.mock("os");
|
||||
|
||||
describe("getFileSystemSuggestions", () => {
|
||||
const mockFs = fs as unknown as {
|
||||
readdirSync: ReturnType<typeof vi.fn>;
|
||||
statSync: ReturnType<typeof vi.fn>;
|
||||
};
|
||||
|
||||
const mockOs = os as unknown as {
|
||||
homedir: ReturnType<typeof vi.fn>;
|
||||
};
|
||||
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
});
|
||||
|
||||
it("returns empty array for empty prefix", () => {
|
||||
expect(getFileSystemSuggestions("")).toEqual([]);
|
||||
});
|
||||
|
||||
it("expands ~ to home directory", () => {
|
||||
mockOs.homedir = vi.fn(() => "/home/testuser");
|
||||
mockFs.readdirSync = vi.fn(() => ["file1.txt", "docs"]);
|
||||
mockFs.statSync = vi.fn((p) => ({
|
||||
isDirectory: () => path.basename(p) === "docs",
|
||||
}));
|
||||
|
||||
const result = getFileSystemSuggestions("~/");
|
||||
|
||||
expect(mockFs.readdirSync).toHaveBeenCalledWith("/home/testuser");
|
||||
expect(result).toEqual([
|
||||
path.join("/home/testuser", "file1.txt"),
|
||||
path.join("/home/testuser", "docs" + path.sep),
|
||||
]);
|
||||
});
|
||||
|
||||
it("filters by prefix if not a directory", () => {
|
||||
mockFs.readdirSync = vi.fn(() => ["abc.txt", "abd.txt", "xyz.txt"]);
|
||||
mockFs.statSync = vi.fn((p) => ({
|
||||
isDirectory: () => p.includes("abd"),
|
||||
}));
|
||||
|
||||
const result = getFileSystemSuggestions("a");
|
||||
expect(result).toEqual(["abc.txt", "abd.txt/"]);
|
||||
});
|
||||
|
||||
it("handles errors gracefully", () => {
|
||||
mockFs.readdirSync = vi.fn(() => {
|
||||
throw new Error("failed");
|
||||
});
|
||||
|
||||
const result = getFileSystemSuggestions("some/path");
|
||||
expect(result).toEqual([]);
|
||||
});
|
||||
|
||||
it("normalizes relative path", () => {
|
||||
mockFs.readdirSync = vi.fn(() => ["foo", "bar"]);
|
||||
mockFs.statSync = vi.fn((_p) => ({
|
||||
isDirectory: () => true,
|
||||
}));
|
||||
|
||||
const result = getFileSystemSuggestions("./");
|
||||
expect(result).toContain("foo/");
|
||||
expect(result).toContain("bar/");
|
||||
});
|
||||
});
|
||||
46
codex-cli/tests/terminal-chat-completions.test.tsx
Normal file
46
codex-cli/tests/terminal-chat-completions.test.tsx
Normal file
@@ -0,0 +1,46 @@
|
||||
import React from "react";
|
||||
import { describe, it, expect } from "vitest";
|
||||
import type { ComponentProps } from "react";
|
||||
import { renderTui } from "./ui-test-helpers.js";
|
||||
import TerminalChatCompletions from "../src/components/chat/terminal-chat-completions.js";
|
||||
|
||||
describe("TerminalChatCompletions", () => {
|
||||
const baseProps: ComponentProps<typeof TerminalChatCompletions> = {
|
||||
completions: ["Option 1", "Option 2", "Option 3", "Option 4", "Option 5"],
|
||||
displayLimit: 3,
|
||||
selectedCompletion: 0,
|
||||
};
|
||||
|
||||
it("renders visible completions within displayLimit", async () => {
|
||||
const { lastFrameStripped } = renderTui(
|
||||
<TerminalChatCompletions {...baseProps} />,
|
||||
);
|
||||
const frame = lastFrameStripped();
|
||||
expect(frame).toContain("Option 1");
|
||||
expect(frame).toContain("Option 2");
|
||||
expect(frame).toContain("Option 3");
|
||||
expect(frame).not.toContain("Option 4");
|
||||
});
|
||||
|
||||
it("centers the selected completion in the visible list", async () => {
|
||||
const { lastFrameStripped } = renderTui(
|
||||
<TerminalChatCompletions {...baseProps} selectedCompletion={2} />,
|
||||
);
|
||||
const frame = lastFrameStripped();
|
||||
expect(frame).toContain("Option 2");
|
||||
expect(frame).toContain("Option 3");
|
||||
expect(frame).toContain("Option 4");
|
||||
expect(frame).not.toContain("Option 1");
|
||||
});
|
||||
|
||||
it("adjusts when selectedCompletion is near the end", async () => {
|
||||
const { lastFrameStripped } = renderTui(
|
||||
<TerminalChatCompletions {...baseProps} selectedCompletion={4} />,
|
||||
);
|
||||
const frame = lastFrameStripped();
|
||||
expect(frame).toContain("Option 3");
|
||||
expect(frame).toContain("Option 4");
|
||||
expect(frame).toContain("Option 5");
|
||||
expect(frame).not.toContain("Option 2");
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user