valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use modifier dim instead of gray and .dim (#2273)

Browse Source 
gray color doesn't work very well with white terminals. `.dim` doesn't
have an effect for some reason.

after:
<img width="1080" height="149" alt="image"
src="https://github.com/user-attachments/assets/26c0f8bb-550d-4d71-bd06-11b3189bc1d7"
/>

Before
<img width="1077" height="186" alt="image"
src="https://github.com/user-attachments/assets/b1fba0c7-bc4d-4da1-9754-6c0a105e8cd1"
/>
This commit is contained in:
aibrahim-oai
2025-08-13 15:50:50 -07:00
committed by GitHub
parent 41eb59a07d
commit cbf972007a
6 changed files with 42 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
codex-rs/tui/src/history_cell.rs
View File

@@ -483,7 +483,7 @@ impl HistoryCell {
} else {
status_str.red()
},
format!(", duration: {duration}").gray(),
format!(", duration: {duration}").dim(),
]);
let mut lines: Vec<Line<'static>> = Vec::new();
@@ -526,7 +526,10 @@ impl HistoryCell {
format!("link: {uri}")
}
};
lines.push(Line::styled(line_text, Style::default().fg(Color::Gray)));
lines.push(Line::styled(
line_text,
Style::default().add_modifier(Modifier::DIM),
));
}
}
@@ -755,7 +758,7 @@ impl HistoryCell {
if empty > 0 {
header.push(Span::styled(
"░".repeat(empty),
Style::default().fg(Color::Gray),
Style::default().add_modifier(Modifier::DIM),
));
}
header.push(Span::raw("] "));
@@ -767,15 +770,15 @@ impl HistoryCell {
let t = s.trim().to_string();
if t.is_empty() { None } else { Some(t) }
}) {
lines.push(Line::from("note".gray().italic()));
lines.push(Line::from("note".dim().italic()));
for l in expl.lines() {
lines.push(Line::from(l.to_string()).gray());
lines.push(Line::from(l.to_string()).dim());
}
}
// Steps styled as checkbox items
if plan.is_empty() {
lines.push(Line::from("(no steps provided)".gray().italic()));
lines.push(Line::from("(no steps provided)".dim().italic()));
} else {
for (idx, PlanItemArg { step, status }) in plan.into_iter().enumerate() {
let (box_span, text_span) = match status {
@@ -783,9 +786,7 @@ impl HistoryCell {
Span::styled("✔", Style::default().fg(Color::Green)),
Span::styled(
step,
Style::default()
.fg(Color::Gray)
.add_modifier(Modifier::CROSSED_OUT | Modifier::DIM),
Style::default().add_modifier(Modifier::CROSSED_OUT | Modifier::DIM),
),
),
StepStatus::InProgress => (
@@ -799,10 +800,7 @@ impl HistoryCell {
),
StepStatus::Pending => (
Span::raw("□"),
Span::styled(
step,
Style::default().fg(Color::Gray).add_modifier(Modifier::DIM),
),
Span::styled(step, Style::default().add_modifier(Modifier::DIM)),
),
};
let prefix = if idx == 0 {
@@ -997,7 +995,7 @@ fn format_mcp_invocation<'a>(invocation: McpInvocation) -> Line<'a> {
Span::raw("."),
Span::styled(invocation.tool.clone(), Style::default().fg(Color::Blue)),
Span::raw("("),
Span::styled(args_str, Style::default().fg(Color::Gray)),
Span::styled(args_str, Style::default().add_modifier(Modifier::DIM)),
Span::raw(")"),
];
Line::from(invocation_spans)