valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove unnecessary flush() calls (#2873)

Browse Source 
Because we are writing to a pipe, these `flush()` calls are unnecessary,
so removing these saves us one syscall per write in these two cases.
This commit is contained in:
Michael Bolin
2025-08-28 22:41:10 -07:00
committed by GitHub
parent 7d734bff65
commit cb2f952143
2 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
codex-rs/mcp-client/src/mcp_client.rs
View File

@@ -129,10 +129,7 @@ impl McpClient {
error!("failed to write newline to child stdin"); error!("failed to write newline to child stdin");
break; break;
} }
if stdin.flush().await.is_err() { // No explicit flush needed on a pipe; write_all is sufficient.
error!("failed to flush child stdin");
break;
}
} }
Err(e) => error!("failed to serialize JSONRPCMessage: {e}"), Err(e) => error!("failed to serialize JSONRPCMessage: {e}"),
} }

4
codex-rs/mcp-server/src/lib.rs
View File

@@ -134,10 +134,6 @@ pub async fn run_main(
error!("Failed to write newline to stdout: {e}"); error!("Failed to write newline to stdout: {e}");
break; break;
} }
if let Err(e) = stdout.flush().await {
error!("Failed to flush stdout: {e}");
break;
}
} }
Err(e) => error!("Failed to serialize JSONRPCMessage: {e}"), Err(e) => error!("Failed to serialize JSONRPCMessage: {e}"),
} }