valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop Mutex before calling tx_approve.send() (#2876)

Browse Source
This commit is contained in:
Michael Bolin
2025-08-28 22:49:29 -07:00
committed by GitHub
parent cb2f952143
commit c988ce28fe
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
codex-rs/core/src/codex.rs
View File

@@ -657,9 +657,17 @@ impl Session {
} }
pub fn notify_approval(&self, sub_id: &str, decision: ReviewDecision) { pub fn notify_approval(&self, sub_id: &str, decision: ReviewDecision) {
let mut state = self.state.lock_unchecked(); let entry = {
if let Some(tx_approve) = state.pending_approvals.remove(sub_id) { let mut state = self.state.lock_unchecked();
tx_approve.send(decision).ok(); state.pending_approvals.remove(sub_id)
};
match entry {
Some(tx_approve) => {
tx_approve.send(decision).ok();
}
None => {
warn!("No pending approval found for sub_id: {sub_id}");
}
} }
} }