feat: reasoning effort as optional (#3527)

Allow the reasoning effort to be optional

codex-rs/tui/src/app.rs

@@ -337,7 +337,7 @@ impl App {
         }
     }
 
-    fn on_update_reasoning_effort(&mut self, effort: ReasoningEffortConfig) {
+    fn on_update_reasoning_effort(&mut self, effort: Option<ReasoningEffortConfig>) {
         let changed = self.config.model_reasoning_effort != effort;
         self.chat_widget.set_reasoning_effort(effort);
         self.config.model_reasoning_effort = effort;
@@ -372,17 +372,18 @@ impl App {
 
         let model = self.config.model.clone();
         let effort = self.config.model_reasoning_effort;
+        let effort_label = effort
+            .map(|effort| effort.to_string())
+            .unwrap_or_else(|| "none".to_string());
         let codex_home = self.config.codex_home.clone();
 
         match scope {
             SaveScope::Profile(profile) => {
-                match persist_model_selection(&codex_home, Some(profile), &model, Some(effort))
-                    .await
-                {
+                match persist_model_selection(&codex_home, Some(profile), &model, effort).await {
                     Ok(()) => {
                         self.model_saved_to_profile = true;
                         self.chat_widget.add_info_message(format!(
-                            "Saved model {model} ({effort}) for profile `{profile}`. Press Ctrl+S again to make this your global default."
+                            "Saved model {model} ({effort_label}) for profile `{profile}`. Press Ctrl+S again to make this your global default."
                         ));
                     }
                     Err(err) => {
@@ -397,11 +398,11 @@ impl App {
                 }
             }
             SaveScope::Global => {
-                match persist_model_selection(&codex_home, None, &model, Some(effort)).await {
+                match persist_model_selection(&codex_home, None, &model, effort).await {
                     Ok(()) => {
                         self.model_saved_to_global = true;
                         self.chat_widget.add_info_message(format!(
-                            "Saved model {model} ({effort}) as your global default."
+                            "Saved model {model} ({effort_label}) as your global default."
                         ));
                     }
                     Err(err) => {
@@ -537,19 +538,19 @@ mod tests {
         let mut app = make_test_app();
         app.model_saved_to_profile = true;
         app.model_saved_to_global = true;
-        app.config.model_reasoning_effort = ReasoningEffortConfig::Medium;
+        app.config.model_reasoning_effort = Some(ReasoningEffortConfig::Medium);
         app.chat_widget
-            .set_reasoning_effort(ReasoningEffortConfig::Medium);
+            .set_reasoning_effort(Some(ReasoningEffortConfig::Medium));
 
-        app.on_update_reasoning_effort(ReasoningEffortConfig::High);
+        app.on_update_reasoning_effort(Some(ReasoningEffortConfig::High));
 
         assert_eq!(
             app.config.model_reasoning_effort,
-            ReasoningEffortConfig::High
+            Some(ReasoningEffortConfig::High)
         );
         assert_eq!(
             app.chat_widget.config_ref().model_reasoning_effort,
-            ReasoningEffortConfig::High
+            Some(ReasoningEffortConfig::High)
         );
         assert!(!app.model_saved_to_profile);
         assert!(!app.model_saved_to_global);

codex-rs/tui/src/app_event.rs

@@ -46,7 +46,7 @@ pub(crate) enum AppEvent {
     CommitTick,
 
     /// Update the current reasoning effort in the running app and widget.
-    UpdateReasoningEffort(ReasoningEffort),
+    UpdateReasoningEffort(Option<ReasoningEffort>),
 
     /// Update the current model slug in the running app and widget.
     UpdateModel(String),

codex-rs/tui/src/chatwidget.rs

@@ -1191,9 +1191,13 @@ impl ChatWidget {
                 tracing::info!(
                     "New model: {}, New effort: {}, Current model: {}, Current effort: {}",
                     model_slug.clone(),
-                    effort,
+                    effort
+                        .map(|effort| effort.to_string())
+                        .unwrap_or_else(|| "none".to_string()),
                     current_model,
                     current_effort
+                        .map(|effort| effort.to_string())
+                        .unwrap_or_else(|| "none".to_string())
                 );
             })];
             items.push(SelectionItem {
@@ -1264,7 +1268,7 @@ impl ChatWidget {
     }
 
     /// Set the reasoning effort in the widget's config copy.
-    pub(crate) fn set_reasoning_effort(&mut self, effort: ReasoningEffortConfig) {
+    pub(crate) fn set_reasoning_effort(&mut self, effort: Option<ReasoningEffortConfig>) {
         self.config.model_reasoning_effort = effort;
     }
 

codex-rs/tui/src/chatwidget/tests.rs

@@ -138,7 +138,7 @@ fn resumed_initial_messages_render_history() {
     let configured = codex_core::protocol::SessionConfiguredEvent {
         session_id: conversation_id,
         model: "test-model".to_string(),
-        reasoning_effort: ReasoningEffortConfig::default(),
+        reasoning_effort: Some(ReasoningEffortConfig::default()),
         history_log_id: 0,
         history_entry_count: 0,
         initial_messages: Some(vec![