fix: remove unnecessary isLoggingEnabled() checks (#420)
It appears that use of `isLoggingEnabled()` was erroneously copypasta'd in many places. This PR updates its docstring to clarify that should only be used to avoid constructing a potentially expensive docstring. With this change, the only function that merits/uses this check is `execCommand()`. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/420). * #423 * __->__ #420 * #419
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
|
||||
import type { FullAutoErrorMode } from "./auto-approval-mode.js";
|
||||
|
||||
import { log, isLoggingEnabled } from "./agent/log.js";
|
||||
import { log } from "./agent/log.js";
|
||||
import { AutoApprovalMode } from "./auto-approval-mode.js";
|
||||
import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
|
||||
import { load as loadYaml, dump as dumpYaml } from "js-yaml";
|
||||
@@ -245,15 +245,11 @@ export const loadConfig = (
|
||||
? resolvePath(cwd, options.projectDocPath)
|
||||
: discoverProjectDocPath(cwd);
|
||||
if (projectDocPath) {
|
||||
if (isLoggingEnabled()) {
|
||||
log(
|
||||
`[codex] Loaded project doc from ${projectDocPath} (${projectDoc.length} bytes)`,
|
||||
);
|
||||
}
|
||||
log(
|
||||
`[codex] Loaded project doc from ${projectDocPath} (${projectDoc.length} bytes)`,
|
||||
);
|
||||
} else {
|
||||
if (isLoggingEnabled()) {
|
||||
log(`[codex] No project doc found in ${cwd}`);
|
||||
}
|
||||
log(`[codex] No project doc found in ${cwd}`);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user