fix: remove unnecessary isLoggingEnabled() checks (#420)
It appears that use of `isLoggingEnabled()` was erroneously copypasta'd in many places. This PR updates its docstring to clarify that should only be used to avoid constructing a potentially expensive docstring. With this change, the only function that merits/uses this check is `execCommand()`. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/openai/codex/pull/420). * #423 * __->__ #420 * #419
This commit is contained in:
@@ -223,23 +223,22 @@ async function execCommand(
|
||||
workdir = process.cwd();
|
||||
}
|
||||
}
|
||||
if (isLoggingEnabled()) {
|
||||
if (applyPatchCommand != null) {
|
||||
log("EXEC running apply_patch command");
|
||||
} else {
|
||||
const { cmd, timeoutInMillis } = execInput;
|
||||
// Seconds are a bit easier to read in log messages and most timeouts
|
||||
// are specified as multiples of 1000, anyway.
|
||||
const timeout =
|
||||
timeoutInMillis != null
|
||||
? Math.round(timeoutInMillis / 1000).toString()
|
||||
: "undefined";
|
||||
log(
|
||||
`EXEC running \`${formatCommandForDisplay(
|
||||
cmd,
|
||||
)}\` in workdir=${workdir} with timeout=${timeout}s`,
|
||||
);
|
||||
}
|
||||
|
||||
if (applyPatchCommand != null) {
|
||||
log("EXEC running apply_patch command");
|
||||
} else if (isLoggingEnabled()) {
|
||||
const { cmd, timeoutInMillis } = execInput;
|
||||
// Seconds are a bit easier to read in log messages and most timeouts
|
||||
// are specified as multiples of 1000, anyway.
|
||||
const timeout =
|
||||
timeoutInMillis != null
|
||||
? Math.round(timeoutInMillis / 1000).toString()
|
||||
: "undefined";
|
||||
log(
|
||||
`EXEC running \`${formatCommandForDisplay(
|
||||
cmd,
|
||||
)}\` in workdir=${workdir} with timeout=${timeout}s`,
|
||||
);
|
||||
}
|
||||
|
||||
// Note execApplyPatch() and exec() are coded defensively and should not
|
||||
|
||||
Reference in New Issue
Block a user