nit: drop instruction override for auto-compact (#4137)

drop instruction override for auto-compact as this is not used and
dangerous as it invalidates the cache
This commit is contained in:
jif-oai
2025-09-24 10:47:12 +01:00
committed by GitHub
parent b90eeabd74
commit af6304c641

View File

@@ -55,7 +55,7 @@ pub(super) async fn run_inline_auto_compact_task(
let input = vec![InputItem::Text { let input = vec![InputItem::Text {
text: SUMMARIZATION_PROMPT.to_string(), text: SUMMARIZATION_PROMPT.to_string(),
}]; }];
run_compact_task_inner(sess, turn_context, sub_id, input, None, false).await; run_compact_task_inner(sess, turn_context, sub_id, input, false).await;
} }
pub(super) async fn run_compact_task( pub(super) async fn run_compact_task(
@@ -71,15 +71,7 @@ pub(super) async fn run_compact_task(
}), }),
}; };
sess.send_event(start_event).await; sess.send_event(start_event).await;
run_compact_task_inner( run_compact_task_inner(sess.clone(), turn_context, sub_id.clone(), input, true).await;
sess.clone(),
turn_context,
sub_id.clone(),
input,
None,
true,
)
.await;
let event = Event { let event = Event {
id: sub_id, id: sub_id,
msg: EventMsg::TaskComplete(TaskCompleteEvent { msg: EventMsg::TaskComplete(TaskCompleteEvent {
@@ -94,7 +86,6 @@ async fn run_compact_task_inner(
turn_context: Arc<TurnContext>, turn_context: Arc<TurnContext>,
sub_id: String, sub_id: String,
input: Vec<InputItem>, input: Vec<InputItem>,
instructions_override: Option<String>,
remove_task_on_completion: bool, remove_task_on_completion: bool,
) { ) {
let initial_input_for_turn: ResponseInputItem = ResponseInputItem::from(input); let initial_input_for_turn: ResponseInputItem = ResponseInputItem::from(input);
@@ -104,9 +95,7 @@ async fn run_compact_task_inner(
let prompt = Prompt { let prompt = Prompt {
input: turn_input, input: turn_input,
tools: Vec::new(), ..Default::default()
base_instructions_override: instructions_override,
output_schema: None,
}; };
let max_retries = turn_context.client.get_provider().stream_max_retries(); let max_retries = turn_context.client.get_provider().stream_max_retries();