valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use continue-on-error: true to tidy up GitHub Action (#871)

Browse Source 
I installed the GitHub Actions extension for VS Code and it started
giving me lint warnings about this line:


a9adb4175c/.github/workflows/rust-ci.yml (L99)

Using an env var to track the state of individual steps was not great,
so I did some research about GitHub actions, which led to the discovery
of combining `continue-on-error: true` with `if .. steps.STEP.outcome ==
'failure'...`.

Apparently there is also a `failure()` macro that is supposed to make
this simpler, but I saw a number of complains online about it not
working as expected. Checking `outcome` seems maybe more reliable at the
cost of being slightly more verbose.
This commit is contained in:
Michael Bolin
2025-05-08 16:21:11 -07:00
committed by GitHub
parent a9adb4175c
commit a538e6acb2
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
.github/workflows/rust-ci.yml vendored
View File

@@ -77,11 +77,10 @@ jobs:
run: | run: |
sudo apt install -y musl-tools pkg-config sudo apt install -y musl-tools pkg-config
- name: Initialize failure flag
run: echo "FAILED=" >> $GITHUB_ENV
- name: cargo clippy - name: cargo clippy
run: cargo clippy --target ${{ matrix.target }} --all-features --tests -- -D warnings || echo "FAILED=${FAILED:+$FAILED, }cargo clippy" >> $GITHUB_ENV id: clippy
continue-on-error: true
run: cargo clippy --target ${{ matrix.target }} --all-features --tests -- -D warnings
# Running `cargo build` from the workspace root builds the workspace using # Running `cargo build` from the workspace root builds the workspace using
# the union of all features from third-party crates. This can mask errors # the union of all features from third-party crates. This can mask errors
@@ -89,15 +88,22 @@ jobs:
# run `cargo build` for each crate individually, though because this is # run `cargo build` for each crate individually, though because this is
# slower, we only do this for the x86_64-unknown-linux-gnu target. # slower, we only do this for the x86_64-unknown-linux-gnu target.
- name: cargo build individual crates - name: cargo build individual crates
id: build
if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }} if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
run: find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo build' || echo "FAILED=${FAILED:+$FAILED, }cargo build individual crates" >> $GITHUB_ENV continue-on-error: true
run: find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo build'
- name: cargo test - name: cargo test
run: cargo test --all-features --target ${{ matrix.target }} || echo "FAILED=${FAILED:+$FAILED, }cargo test" >> $GITHUB_ENV id: test
continue-on-error: true
run: cargo test --all-features --target ${{ matrix.target }}
- name: Fail if any step failed # Fail the job if any of the previous steps failed.
if: env.FAILED != '' - name: verify all steps passed
if: |
steps.clippy.outcome == 'failure' ||
steps.build.outcome == 'failure' ||
steps.test.outcome == 'failure'
run: | run: |
echo "See logs above, as the following steps failed:" echo "One or more checks failed (clippy, build, or test). See logs for details."
echo "$FAILED"
exit 1 exit 1