valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: flipped the sense of Prompt.store in #642 (#663)

Browse Source 
I got the sense of this wrong in
https://github.com/openai/codex/pull/642. In that PR, I made
`--disable-response-storage` work, but broke the default case.

With this fix, both cases work and I think the code is a bit cleaner.
This commit is contained in:
Michael Bolin
2025-04-25 13:41:17 -07:00
committed by GitHub
parent 7d9de34bc7
commit 9c3ebac3b7
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
codex-rs/core/src/codex.rs
View File

@@ -677,13 +677,15 @@ async fn run_turn(
let (prev_id, store, is_first_turn) = { let (prev_id, store, is_first_turn) = {
let state = sess.state.lock().unwrap(); let state = sess.state.lock().unwrap();
let is_first_turn = state.previous_response_id.is_none(); let is_first_turn = state.previous_response_id.is_none();
if state.zdr_transcript.is_some() { let store = state.zdr_transcript.is_none();
let prev_id = if store {
state.previous_response_id.clone()
} else {
// When using ZDR, the Reponses API may send previous_response_id // When using ZDR, the Reponses API may send previous_response_id
// back, but trying to use it results in a 400. // back, but trying to use it results in a 400.
(None, true, is_first_turn) None
} else { };
(state.previous_response_id.clone(), false, is_first_turn) (prev_id, store, is_first_turn)
}
}; };
let instructions = if is_first_turn { let instructions = if is_first_turn {