Back out @lib indirection in tsconfig.json (#111)

This commit is contained in:
Michael Bolin
2025-04-16 14:16:53 -07:00
committed by GitHub
parent 7ac633b69c
commit 9b733fc48f
41 changed files with 63 additions and 111 deletions

View File

@@ -64,13 +64,13 @@ vi.mock("openai", () => {
};
});
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -71,13 +71,13 @@ vi.mock("openai", () => {
});
// Stub helpers not relevant for this test.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -67,11 +67,11 @@ vi.mock("openai", () => {
});
// Stubs for external helpers referenced indirectly.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -47,7 +47,7 @@ vi.mock("openai", () => {
});
// Mock the approvals and formatCommand helpers referenced by handleexeccommand.
vi.mock("@lib/approvals.js", () => {
vi.mock("../src/approvals.js", () => {
return {
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
@@ -57,7 +57,7 @@ vi.mock("@lib/approvals.js", () => {
};
});
vi.mock("@lib/format-command.js", () => {
vi.mock("../src/format-command.js", () => {
return {
__esModule: true,
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),

View File

@@ -88,14 +88,14 @@ vi.mock("openai", () => {
});
// Stub approvals & command formatting not relevant for this test.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -23,14 +23,14 @@ vi.mock("openai", () => {
});
// Stub approvals / formatting helpers unrelated to network handling.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -22,14 +22,14 @@ vi.mock("openai", () => {
};
});
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -22,14 +22,14 @@ vi.mock("openai", () => {
};
});
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -42,14 +42,14 @@ vi.mock("openai", () => {
});
// Stub approvals / formatting helpers not relevant here.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -51,7 +51,7 @@ vi.mock("openai", () => {
// The AgentLoop pulls these helpers in order to decide whether a command can
// be autoapproved. None of that matters for this test, so we stub the module
// with minimal noop implementations.
vi.mock("@lib/approvals.js", () => {
vi.mock("../src/approvals.js", () => {
return {
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
@@ -61,7 +61,7 @@ vi.mock("@lib/approvals.js", () => {
};
});
vi.mock("@lib/format-command.js", () => {
vi.mock("../src/format-command.js", () => {
return {
__esModule: true,
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),

View File

@@ -34,14 +34,14 @@ vi.mock("openai", () => {
// Stub helpers that the agent indirectly imports so it does not attempt any
// filesystem access or real approvals logic during the test.
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -32,14 +32,14 @@ vi.mock("openai", () => {
};
});
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
canAutoApprove: () => ({ type: "auto-approve", runInSandbox: false } as any),
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -49,7 +49,7 @@ vi.mock("openai", () => {
// --- Helpers referenced by handleexeccommand -----------------------------
vi.mock("@lib/approvals.js", () => {
vi.mock("../src/approvals.js", () => {
return {
__esModule: true,
alwaysApprovedCommands: new Set<string>(),
@@ -59,7 +59,7 @@ vi.mock("@lib/approvals.js", () => {
};
});
vi.mock("@lib/format-command.js", () => {
vi.mock("../src/format-command.js", () => {
return {
__esModule: true,
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),

View File

@@ -74,12 +74,12 @@ vi.mock("openai", () => {
});
// Stub helpers referenced indirectly so we do not pull in real FS/network
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
__esModule: true,
isSafeCommand: () => null,
}));
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
__esModule: true,
formatCommandForDisplay: (c: Array<string>) => c.join(" "),
}));

View File

@@ -1,6 +1,6 @@
import type { SafetyAssessment } from "../src/lib/approvals";
import type { SafetyAssessment } from "../src/approvals";
import { canAutoApprove } from "../src/lib/approvals";
import { canAutoApprove } from "../src/approvals";
import { describe, test, expect } from "vitest";
describe("canAutoApprove()", () => {

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer";
import TextBuffer from "../src/text-buffer";
import { describe, it, expect, vi } from "vitest";
/* -------------------------------------------------------------------------

View File

@@ -1,4 +1,4 @@
import { formatCommandForDisplay } from "../src/lib/format-command";
import { formatCommandForDisplay } from "../src/format-command";
import { describe, test, expect } from "vitest";
describe("formatCommandForDisplay()", () => {

View File

@@ -22,7 +22,7 @@ describe("rawExec invalid command handling", () => {
// ---------------------------------------------------------------------------
// Mock approvals and logging helpers so the test focuses on execution flow.
vi.mock("@lib/approvals.js", () => {
vi.mock("../src/approvals.js", () => {
return {
__esModule: true,
canAutoApprove: () =>
@@ -31,7 +31,7 @@ vi.mock("@lib/approvals.js", () => {
};
});
vi.mock("@lib/format-command.js", () => {
vi.mock("../src/format-command.js", () => {
return {
__esModule: true,
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),

View File

@@ -1,6 +1,6 @@
import { renderTui } from "./ui-test-helpers.js";
import MultilineTextEditor from "../src/components/chat/multiline-editor.js";
import TextBuffer from "../src/lib/text-buffer.js";
import TextBuffer from "../src/text-buffer.js";
import * as React from "react";
import { describe, it, expect, vi } from "vitest";

View File

@@ -34,12 +34,12 @@ vi.mock("../src/utils/input-utils.js", () => ({
})),
}));
// Mock the optional @lib/* dependencies so the dynamic import in parsers.ts
// Mock the optional ../src/* dependencies so the dynamic import in parsers.ts
// does not fail during the test environment where the alias isn't configured.
vi.mock("@lib/format-command.js", () => ({
vi.mock("../src/format-command.js", () => ({
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),
}));
vi.mock("@lib/approvals.js", () => ({
vi.mock("../src/approvals.js", () => ({
isSafeCommand: (_cmd: Array<string>) => null,
}));

View File

@@ -1,4 +1,4 @@
import { parseApplyPatch } from "../src/lib/parse-apply-patch";
import { parseApplyPatch } from "../src/parse-apply-patch";
import { expect, test, describe } from "vitest";
// Helper function to unwrap a nonnull result in tests that expect success.

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer.js";
import TextBuffer from "../src/text-buffer.js";
import { describe, it, expect } from "vitest";
// These tests ensure that the TextBuffer copy&paste logic keeps parity with

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer.js";
import TextBuffer from "../src/text-buffer.js";
import { describe, it, expect } from "vitest";
describe("TextBuffer newline normalisation", () => {

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer";
import TextBuffer from "../src/text-buffer";
import { describe, it, expect } from "vitest";
// The purpose of this testsuite is NOT to make the implementation green today

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer.js";
import TextBuffer from "../src/text-buffer.js";
import { describe, test, expect } from "vitest";
describe("TextBuffer wordwise navigation & deletion", () => {

View File

@@ -1,4 +1,4 @@
import TextBuffer from "../src/lib/text-buffer";
import TextBuffer from "../src/text-buffer";
import { describe, it, expect } from "vitest";
describe("TextBuffer basic editing parity with Rust suite", () => {