Update cargo to 2024 edition (#842)

Some effects of this change:
- New formatting changes across many files. No functionality changes
should occur from that.
- Calls to `set_env` are considered unsafe, since this only happens in
tests we wrap them in `unsafe` blocks

codex-rs/tui/src/app.rs

@@ -12,9 +12,9 @@ use crossterm::event::KeyCode;
 use crossterm::event::KeyEvent;
 use crossterm::event::MouseEvent;
 use crossterm::event::MouseEventKind;
-use std::sync::mpsc::channel;
 use std::sync::mpsc::Receiver;
 use std::sync::mpsc::Sender;
+use std::sync::mpsc::channel;
 
 /// Top‑level application state – which full‑screen view is currently active.
 enum AppState {

codex-rs/tui/src/chatwidget.rs

@@ -1,7 +1,7 @@
 use std::path::PathBuf;
+use std::sync::Arc;
 use std::sync::mpsc::SendError;
 use std::sync::mpsc::Sender;
-use std::sync::Arc;
 
 use codex_core::codex_wrapper::init_codex;
 use codex_core::config::Config;
@@ -17,8 +17,8 @@ use ratatui::layout::Layout;
 use ratatui::layout::Rect;
 use ratatui::widgets::Widget;
 use ratatui::widgets::WidgetRef;
-use tokio::sync::mpsc::unbounded_channel;
 use tokio::sync::mpsc::UnboundedSender;
+use tokio::sync::mpsc::unbounded_channel;
 
 use crate::app_event::AppEvent;
 use crate::bottom_pane::BottomPane;

codex-rs/tui/src/lib.rs

@@ -12,8 +12,8 @@ use codex_core::util::is_inside_git_repo;
 use log_layer::TuiLogLayer;
 use std::fs::OpenOptions;
 use tracing_appender::non_blocking;
-use tracing_subscriber::prelude::*;
 use tracing_subscriber::EnvFilter;
+use tracing_subscriber::prelude::*;
 
 mod app;
 mod app_event;

codex-rs/tui/src/log_layer.rs

@@ -11,13 +11,13 @@
 use std::fmt::Write as _;
 
 use tokio::sync::mpsc::UnboundedSender;
-use tracing::field::Field;
-use tracing::field::Visit;
 use tracing::Event;
 use tracing::Subscriber;
+use tracing::field::Field;
+use tracing::field::Visit;
+use tracing_subscriber::Layer;
 use tracing_subscriber::layer::Context;
 use tracing_subscriber::registry::LookupSpan;
-use tracing_subscriber::Layer;
 
 /// Maximum characters forwarded to the TUI. Longer messages are truncated so the
 /// single‑line status indicator cannot overflow the viewport.

codex-rs/tui/src/main.rs

@@ -1,6 +1,6 @@
 use clap::Parser;
-use codex_tui::run_main;
 use codex_tui::Cli;
+use codex_tui::run_main;
 
 #[tokio::main]
 async fn main() -> std::io::Result<()> {

codex-rs/tui/src/scroll_event_helper.rs

@@ -1,12 +1,12 @@
+use std::sync::Arc;
 use std::sync::atomic::AtomicBool;
 use std::sync::atomic::AtomicI32;
 use std::sync::atomic::Ordering;
 use std::sync::mpsc::Sender;
-use std::sync::Arc;
 
 use tokio::runtime::Handle;
-use tokio::time::sleep;
 use tokio::time::Duration;
+use tokio::time::sleep;
 
 use crate::app_event::AppEvent;
 

codex-rs/tui/src/status_indicator_widget.rs

@@ -6,11 +6,11 @@
 //! [`StatusIndicatorWidget::update_text`], the parent widget triggers a
 //! redraw so the change is visible immediately.
 
+use std::sync::Arc;
 use std::sync::atomic::AtomicBool;
 use std::sync::atomic::AtomicUsize;
 use std::sync::atomic::Ordering;
 use std::sync::mpsc::Sender;
-use std::sync::Arc;
 use std::thread;
 use std::time::Duration;
 

codex-rs/tui/src/tui.rs

@@ -1,16 +1,16 @@
-use std::io::stdout;
 use std::io::Stdout;
+use std::io::stdout;
 use std::io::{self};
 
 use crossterm::event::DisableMouseCapture;
 use crossterm::event::EnableMouseCapture;
+use ratatui::Terminal;
 use ratatui::backend::CrosstermBackend;
 use ratatui::crossterm::execute;
-use ratatui::crossterm::terminal::disable_raw_mode;
-use ratatui::crossterm::terminal::enable_raw_mode;
 use ratatui::crossterm::terminal::EnterAlternateScreen;
 use ratatui::crossterm::terminal::LeaveAlternateScreen;
-use ratatui::Terminal;
+use ratatui::crossterm::terminal::disable_raw_mode;
+use ratatui::crossterm::terminal::enable_raw_mode;
 
 /// A type alias for the terminal type used in this application
 pub type Tui = Terminal<CrosstermBackend<Stdout>>;

codex-rs/tui/src/user_approval_widget.rs

@@ -26,8 +26,8 @@ use ratatui::widgets::List;
 use ratatui::widgets::Paragraph;
 use ratatui::widgets::Widget;
 use ratatui::widgets::WidgetRef;
-use tui_input::backend::crossterm::EventHandler;
 use tui_input::Input;
+use tui_input::backend::crossterm::EventHandler;
 
 use crate::app_event::AppEvent;
 use crate::exec_command::relativize_to_home;