valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent dismissal of login menu in TUI (#6285)

Browse Source 
We currently allow the user to dismiss the login menu via Ctrl+C. This
leaves them in a bad state where they're not auth'ed but have an input
prompt. In the extension, this isn't a problem because we don't allow
the user to dismiss the login screen.

Testing: I confirmed that Ctrl+C no longer dismisses the login menu.

This is an alternative (simpler) fix for a [community
PR](https://github.com/openai/codex/pull/3234).
This commit is contained in:
Eric Traut
2025-11-05 16:25:58 -06:00
committed by GitHub
parent 05f0b4f590
commit 86c149ae8e
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
codex-rs/tui/src/onboarding/onboarding_screen.rs
View File

@@ -170,6 +170,12 @@ impl OnboardingScreen {
out out
} }
fn is_auth_in_progress(&self) -> bool {
self.steps.iter().any(|step| {
matches!(step, Step::Auth(_)) && matches!(step.get_step_state(), StepState::InProgress)
})
}
pub(crate) fn is_done(&self) -> bool { pub(crate) fn is_done(&self) -> bool {
self.is_done self.is_done
|| !self || !self
@@ -216,7 +222,9 @@ impl KeyboardHandler for OnboardingScreen {
kind: KeyEventKind::Press, kind: KeyEventKind::Press,
.. ..
} => { } => {
self.is_done = true; if !self.is_auth_in_progress() {
self.is_done = true;
}
} }
_ => { _ => {
if let Some(Step::Welcome(widget)) = self if let Some(Step::Welcome(widget)) = self