valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: drop d as keyboard shortcut for scrolling in the TUI (#704)

Browse Source 
The existing `b` and `space` are sufficient and `d` and `u` default to
half-page scrolling in `less`, so the way we supported `d` and `u`
wasn't faithful to that, anyway:

https://man7.org/linux/man-pages/man1/less.1.html

If we decide to bring `d` and `u` back, they should probably match
`less`?
This commit is contained in:
Michael Bolin
2025-04-28 10:39:58 -07:00
committed by GitHub
parent fa5fa8effc
commit 77e2918049
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
codex-rs/tui/src/conversation_history_widget.rs
View File

@@ -48,11 +48,11 @@ impl ConversationHistoryWidget {
self.scroll_down(1); self.scroll_down(1);
true true
} }
KeyCode::PageUp | KeyCode::Char('b') | KeyCode::Char('u') | KeyCode::Char('U') => { KeyCode::PageUp | KeyCode::Char('b') => {
self.scroll_page_up(); self.scroll_page_up();
true true
} }
KeyCode::PageDown | KeyCode::Char(' ') | KeyCode::Char('d') | KeyCode::Char('D') => { KeyCode::PageDown | KeyCode::Char(' ') => {
self.scroll_page_down(); self.scroll_page_down();
true true
} }
@@ -238,7 +238,7 @@ impl WidgetRef for ConversationHistoryWidget {
fn render_ref(&self, area: Rect, buf: &mut Buffer) { fn render_ref(&self, area: Rect, buf: &mut Buffer) {
let (title, border_style) = if self.has_input_focus { let (title, border_style) = if self.has_input_focus {
( (
"Messages (↑/↓ or j/k = line, b/u = PgUp, space/d = PgDn)", "Messages (↑/↓ or j/k = line, b/space = page)",
Style::default().fg(Color::LightYellow), Style::default().fg(Color::LightYellow),
) )
} else { } else {