fix: configure husky and lint-staged for pnpm monorepo (#384)
# Improve Developer Experience with Husky and lint-staged for pnpm Monorepo ## Summary This PR enhances the developer experience by configuring Husky and lint-staged to work properly with our pnpm monorepo structure. It centralizes Git hooks at the root level and ensures consistent code quality across the project. ## Changes - Centralized Husky and lint-staged configuration at the monorepo root - Added pre-commit hook that runs lint-staged to enforce code quality - Configured lint-staged to: - Format JSON, MD, and YAML files with Prettier - Lint and typecheck TypeScript files before commits - Fixed release script in codex-cli package.json (changed "pmpm" to "npm publish") - Removed duplicate Husky and lint-staged configurations from codex-cli package.json ## Benefits - **Consistent Code Quality**: Ensures all committed code meets project standards - **Automated Formatting**: Automatically formats code during commits - **Early Error Detection**: Catches type errors and lint issues before they're committed - **Centralized Configuration**: Easier to maintain and update in one place - **Improved Collaboration**: Ensures consistent code style across the team ## Future Improvements We could further enhance this setup by **Commit Message Validation**: Add commitlint to enforce conventional commit messages --------- Co-authored-by: Thibault Sottiaux <tibo@openai.com>
This commit is contained in:
13
package.json
13
package.json
@@ -10,12 +10,14 @@
|
||||
"test": "pnpm --filter @openai/codex run test",
|
||||
"lint": "pnpm --filter @openai/codex run lint",
|
||||
"typecheck": "pnpm --filter @openai/codex run typecheck",
|
||||
"changelog": "git-cliff --config cliff.toml --output CHANGELOG.ignore.md $LAST_RELEASE_TAG..HEAD",
|
||||
"prepare": "husky",
|
||||
"changelog": "git-cliff --config cliff.toml --output CHANGELOG.ignore.md $LAST_RELEASE_TAG..HEAD"
|
||||
"husky:add": "husky add"
|
||||
},
|
||||
"devDependencies": {
|
||||
"git-cliff": "^2.8.0",
|
||||
"husky": "^9.1.7",
|
||||
"lint-staged": "^15.5.1",
|
||||
"prettier": "^3.5.3"
|
||||
},
|
||||
"resolutions": {
|
||||
@@ -30,5 +32,14 @@
|
||||
"node": ">=22",
|
||||
"pnpm": ">=9.0.0"
|
||||
},
|
||||
"lint-staged": {
|
||||
"*.json": "prettier --write",
|
||||
"*.md": "prettier --write",
|
||||
".github/workflows/*.yml": "prettier --write",
|
||||
"**/*.{js,ts,tsx}": [
|
||||
"pnpm --filter @openai/codex run lint",
|
||||
"pnpm --filter @openai/codex run typecheck"
|
||||
]
|
||||
},
|
||||
"packageManager": "pnpm@10.8.1"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user