valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove the · animation (#2271)

Browse Source 
the pulsing dot felt too noisy to me next to the shimmering "Working"
text. we'll bring it back for streaming response text perhaps?
This commit is contained in:
Jeremy Rose
2025-08-14 15:30:41 -04:00
committed by GitHub
parent 544980c008
commit 475ba13479
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
codex-rs/tui/src/status_indicator_widget.rs
View File

@@ -217,17 +217,6 @@ impl WidgetRef for StatusIndicatorWidget {
let mut spans: Vec<Span<'static>> = Vec::new(); let mut spans: Vec<Span<'static>> = Vec::new();
spans.push(Span::styled("▌ ", Style::default().fg(Color::Cyan))); spans.push(Span::styled("▌ ", Style::default().fg(Color::Cyan)));
// Simple dim spinner to the left of the header.
let spinner_frames = ['·', '•', '●', '•'];
const SPINNER_SLOWDOWN: usize = 2;
let spinner_ch = spinner_frames[(idx / SPINNER_SLOWDOWN) % spinner_frames.len()];
spans.push(Span::styled(
spinner_ch.to_string(),
Style::default().add_modifier(Modifier::DIM),
));
spans.push(Span::raw(" "));
// Space after header
// Animated header after the left bar // Animated header after the left bar
spans.extend(animated_spans); spans.extend(animated_spans);
// Space between header and bracket block // Space between header and bracket block
@@ -336,7 +325,7 @@ mod tests {
} }
#[test] #[test]
fn spinner_is_rendered() { fn header_starts_at_expected_position() {
let (tx_raw, _rx) = channel::<AppEvent>(); let (tx_raw, _rx) = channel::<AppEvent>();
let tx = AppEventSender::new(tx_raw); let tx = AppEventSender::new(tx_raw);
let mut w = StatusIndicatorWidget::new(tx); let mut w = StatusIndicatorWidget::new(tx);
@@ -348,9 +337,6 @@ mod tests {
w.render_ref(area, &mut buf); w.render_ref(area, &mut buf);
let ch = buf[(2, 0)].symbol().chars().next().unwrap_or(' '); let ch = buf[(2, 0)].symbol().chars().next().unwrap_or(' ');
assert!( assert_eq!(ch, 'W', "expected Working header at col 2: {ch:?}");
matches!(ch, '·' | '•' | '●'),
"expected spinner char at col 2: {ch:?}"
);
} }
} }