valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: skip cargo test for release builds on ordinary CI because it is slow, particularly with --all-features set (#2276)

Browse Source 
I put this PR together because I noticed I have to wait quite a bit
longer on my PRs since we added
https://github.com/openai/codex/pull/2242 to catch more build issues.

I think we should think about reigning in our use of create features,
but this should be good enough to speed things up for now.
This commit is contained in:
Michael Bolin
2025-08-13 16:27:20 -07:00
committed by GitHub
parent bb9ce3cb78
commit 3a0656df63
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
.github/workflows/rust-ci.yml vendored
View File

@@ -53,15 +53,9 @@ jobs:
- runner: macos-14 - runner: macos-14
target: x86_64-apple-darwin target: x86_64-apple-darwin
profile: dev profile: dev
- runner: macos-14
target: aarch64-apple-darwin
profile: release
- runner: ubuntu-24.04 - runner: ubuntu-24.04
target: x86_64-unknown-linux-musl target: x86_64-unknown-linux-musl
profile: dev profile: dev
- runner: ubuntu-24.04
target: x86_64-unknown-linux-musl
profile: release
- runner: ubuntu-24.04 - runner: ubuntu-24.04
target: x86_64-unknown-linux-gnu target: x86_64-unknown-linux-gnu
profile: dev profile: dev
@@ -75,6 +69,15 @@ jobs:
target: x86_64-pc-windows-msvc target: x86_64-pc-windows-msvc
profile: dev profile: dev
# Also run representative release builds on Mac and Linux because
# there could be release-only build errors we want to catch.
- runner: macos-14
target: aarch64-apple-darwin
profile: release
- runner: ubuntu-24.04
target: x86_64-unknown-linux-musl
profile: release
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@1.88 - uses: dtolnay/rust-toolchain@1.88
@@ -108,12 +111,14 @@ jobs:
# slower, we only do this for the x86_64-unknown-linux-gnu target. # slower, we only do this for the x86_64-unknown-linux-gnu target.
- name: cargo build individual crates - name: cargo build individual crates
id: build id: build
if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }} if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' && matrix.profile != 'release' }}
continue-on-error: true continue-on-error: true
run: find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo build --profile ${{ matrix.profile }}' run: find . -name Cargo.toml -mindepth 2 -maxdepth 2 -print0 | xargs -0 -n1 -I{} bash -c 'cd "$(dirname "{}")" && cargo build --profile ${{ matrix.profile }}'
- name: cargo test - name: cargo test
id: test id: test
# `cargo test` takes too long for release builds to run them on every PR
if: ${{ matrix.profile != 'release' }}
continue-on-error: true continue-on-error: true
run: cargo test --all-features --target ${{ matrix.target }} --profile ${{ matrix.profile }} run: cargo test --all-features --target ${{ matrix.target }} --profile ${{ matrix.profile }}
env: env: