From 2759ff39daf37b7f1bfcdba8e9736ac956c03b94 Mon Sep 17 00:00:00 2001
From: Pulipaka Sai Krishna <31779125+skpulipaka26@users.noreply.github.com>
Date: Fri, 25 Apr 2025 11:38:05 -0500
Subject: [PATCH] fix: model selection (#643)

fix: pass correct selected model in ModelOverlay

The ModelOverlay component was incorrectly passing the current model
instead of the newly selected model to its onSelect callback. This
prevented model changes from being applied properly.

The fix ensures that when a user selects a new model, the parent
component receives the correct newly selected model value, allowing
model changes to work as intended.
---
 codex-cli/src/components/model-overlay.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/codex-cli/src/components/model-overlay.tsx b/codex-cli/src/components/model-overlay.tsx
index 28b2575a..86a7e585 100644
--- a/codex-cli/src/components/model-overlay.tsx
+++ b/codex-cli/src/components/model-overlay.tsx
@@ -153,10 +153,10 @@ export default function ModelOverlay({
       }
       initialItems={items}
       currentValue={currentModel}
-      onSelect={() =>
+      onSelect={(selectedModel) =>
         onSelect(
           items?.map((m) => m.value),
-          currentModel,
+          selectedModel,
         )
       }
       onExit={onExit}