valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NIT unified exec (#3479)

Browse Source 
Fix the default value of the experimental flag of unified_exec
This commit is contained in:
jif-oai
2025-09-11 09:19:12 -07:00
committed by GitHub
parent e13b35ecb0
commit 114ce9ff4d
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
codex-rs/core/src/config.rs
View File

@@ -835,7 +835,7 @@ impl Config {
.unwrap_or(false), .unwrap_or(false),
use_experimental_unified_exec_tool: cfg use_experimental_unified_exec_tool: cfg
.experimental_use_unified_exec_tool .experimental_use_unified_exec_tool
.unwrap_or(true), .unwrap_or(false),
include_view_image_tool, include_view_image_tool,
active_profile: active_profile_name, active_profile: active_profile_name,
disable_paste_burst: cfg.disable_paste_burst.unwrap_or(false), disable_paste_burst: cfg.disable_paste_burst.unwrap_or(false),
@@ -1210,7 +1210,7 @@ model_verbosity = "high"
include_apply_patch_tool: false, include_apply_patch_tool: false,
tools_web_search_request: false, tools_web_search_request: false,
use_experimental_streamable_shell_tool: false, use_experimental_streamable_shell_tool: false,
use_experimental_unified_exec_tool: true, use_experimental_unified_exec_tool: false,
include_view_image_tool: true, include_view_image_tool: true,
active_profile: Some("o3".to_string()), active_profile: Some("o3".to_string()),
disable_paste_burst: false, disable_paste_burst: false,
@@ -1267,7 +1267,7 @@ model_verbosity = "high"
include_apply_patch_tool: false, include_apply_patch_tool: false,
tools_web_search_request: false, tools_web_search_request: false,
use_experimental_streamable_shell_tool: false, use_experimental_streamable_shell_tool: false,
use_experimental_unified_exec_tool: true, use_experimental_unified_exec_tool: false,
include_view_image_tool: true, include_view_image_tool: true,
active_profile: Some("gpt3".to_string()), active_profile: Some("gpt3".to_string()),
disable_paste_burst: false, disable_paste_burst: false,
@@ -1339,7 +1339,7 @@ model_verbosity = "high"
include_apply_patch_tool: false, include_apply_patch_tool: false,
tools_web_search_request: false, tools_web_search_request: false,
use_experimental_streamable_shell_tool: false, use_experimental_streamable_shell_tool: false,
use_experimental_unified_exec_tool: true, use_experimental_unified_exec_tool: false,
include_view_image_tool: true, include_view_image_tool: true,
active_profile: Some("zdr".to_string()), active_profile: Some("zdr".to_string()),
disable_paste_burst: false, disable_paste_burst: false,
@@ -1397,7 +1397,7 @@ model_verbosity = "high"
include_apply_patch_tool: false, include_apply_patch_tool: false,
tools_web_search_request: false, tools_web_search_request: false,
use_experimental_streamable_shell_tool: false, use_experimental_streamable_shell_tool: false,
use_experimental_unified_exec_tool: true, use_experimental_unified_exec_tool: false,
include_view_image_tool: true, include_view_image_tool: true,
active_profile: Some("gpt5".to_string()), active_profile: Some("gpt5".to_string()),
disable_paste_burst: false, disable_paste_burst: false,

3
codex-rs/core/tests/suite/prompt_caching.rs
View File

@@ -191,8 +191,7 @@ async fn prompt_tools_are_consistent_across_requests() {
let expected_instructions: &str = include_str!("../../prompt.md"); let expected_instructions: &str = include_str!("../../prompt.md");
// our internal implementation is responsible for keeping tools in sync // our internal implementation is responsible for keeping tools in sync
// with the OpenAI schema, so we just verify the tool presence here // with the OpenAI schema, so we just verify the tool presence here
let expected_tools_names: &[&str] = let expected_tools_names: &[&str] = &["shell", "update_plan", "apply_patch", "view_image"];
&["unified_exec", "update_plan", "apply_patch", "view_image"];
let body0 = requests[0].body_json::<serde_json::Value>().unwrap(); let body0 = requests[0].body_json::<serde_json::Value>().unwrap();
assert_eq!( assert_eq!(
body0["instructions"], body0["instructions"],