valknar/llmx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove unused _writableRoots arg to exec() function (#762)

Browse Source 
I suspect this was done originally so that `execForSandbox()` had a
consistent signature for both the `SandboxType.NONE` and
`SandboxType.MACOS_SEATBELT` cases, but that is not really necessary and
turns out to make the upcoming Landlock support a bit more complicated
to implement, so I had Codex remove it and clean up the call sites.
This commit is contained in:
Michael Bolin
2025-04-30 14:08:27 -07:00
committed by GitHub
parent e6fe8d6fa1
commit 033d379eca
6 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-cli/tests/cancel-exec.test.ts
View File

@@ -14,7 +14,7 @@ describe("exec cancellation", () => {
const cmd = ["node", "-e", "setTimeout(() => console.log('late'), 5000);"];
const start = Date.now();
const promise = rawExec(cmd, {}, [], abortController.signal);
const promise = rawExec(cmd, {}, abortController.signal);
// Abort almost immediately.
abortController.abort();
@@ -38,7 +38,7 @@ describe("exec cancellation", () => {
const cmd = ["node", "-e", "console.log('finished')"];
const result = await rawExec(cmd, {}, [], abortController.signal);
const result = await rawExec(cmd, {}, abortController.signal);
expect(result.exitCode).toBe(0);
expect(result.stdout.trim()).toBe("finished");