2025-09-24 10:27:35 -07:00
|
|
|
use thiserror::Error;
|
|
|
|
|
|
|
|
|
|
#[derive(Debug, Error, PartialEq)]
|
|
|
|
|
pub enum FunctionCallError {
|
|
|
|
|
#[error("{0}")]
|
|
|
|
|
RespondToModel(String),
|
2025-10-17 10:06:55 +01:00
|
|
|
#[error("{0}")]
|
2025-10-20 20:57:37 +01:00
|
|
|
#[allow(dead_code)] // TODO(jif) fix in a follow-up PR
|
2025-10-17 10:06:55 +01:00
|
|
|
Denied(String),
|
chore: refactor tool handling (#4510)
# Tool System Refactor
- Centralizes tool definitions and execution in `core/src/tools/*`:
specs (`spec.rs`), handlers (`handlers/*`), router (`router.rs`),
registry/dispatch (`registry.rs`), and shared context (`context.rs`).
One registry now builds the model-visible tool list and binds handlers.
- Router converts model responses to tool calls; Registry dispatches
with consistent telemetry via `codex-rs/otel` and unified error
handling. Function, Local Shell, MCP, and experimental `unified_exec`
all flow through this path; legacy shell aliases still work.
- Rationale: reduce per‑tool boilerplate, keep spec/handler in sync, and
make adding tools predictable and testable.
Example: `read_file`
- Spec: `core/src/tools/spec.rs` (see `create_read_file_tool`,
registered by `build_specs`).
- Handler: `core/src/tools/handlers/read_file.rs` (absolute `file_path`,
1‑indexed `offset`, `limit`, `L#: ` prefixes, safe truncation).
- E2E test: `core/tests/suite/read_file.rs` validates the tool returns
the requested lines.
## Next steps:
- Decompose `handle_container_exec_with_params`
- Add parallel tool calls
2025-10-03 13:21:06 +01:00
|
|
|
#[error("LocalShellCall without call_id or id")]
|
|
|
|
|
MissingLocalShellCallId,
|
|
|
|
|
#[error("Fatal error: {0}")]
|
|
|
|
|
Fatal(String),
|
2025-09-24 10:27:35 -07:00
|
|
|
}
|
