valknar/audio-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: install lamejs from GitHub repo for proper browser support

Browse Source 
Switched from npm package to GitHub repo (github:zhuker/lamejs) which
includes the proper browser build. Reverted to simple dynamic import.

Fixes MP3 export MPEGMode reference error.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Sebastian Krüger
2025-11-19 08:11:46 +01:00
parent 77916d4d07
commit d5c84d35e4
3 changed files with 9 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lib/audio/export.ts
View File

@@ -129,31 +129,6 @@ export function downloadArrayBuffer(
URL.revokeObjectURL(url);
}
/**
* Load lamejs library dynamically
*/
async function loadLamejs(): Promise<any> {
// Check if already loaded
if (typeof window !== 'undefined' && (window as any).lamejs) {
return (window as any).lamejs;
}
// Load the script from node_modules
return new Promise((resolve, reject) => {
const script = document.createElement('script');
script.src = '/node_modules/.pnpm/lamejs@1.2.1/node_modules/lamejs/lame.min.js';
script.onload = () => {
if ((window as any).lamejs) {
resolve((window as any).lamejs);
} else {
reject(new Error('lamejs failed to load'));
}
};
script.onerror = () => reject(new Error('Failed to load lamejs script'));
document.head.appendChild(script);
});
}
/**
* Convert an AudioBuffer to MP3
*/
@@ -161,8 +136,8 @@ export async function audioBufferToMp3(
audioBuffer: AudioBuffer,
options: ExportOptions = { format: 'mp3', bitrate: 192 }
): Promise<ArrayBuffer> {
// Load lamejs library
const lamejs = await loadLamejs();
// Dynamically import lamejs from GitHub repo (has proper browser build)
const lamejs = await import('lamejs');
const { bitrate = 192, normalize } = options;
const numberOfChannels = Math.min(audioBuffer.numberOfChannels, 2); // MP3 supports max 2 channels

2
package.json
View File

@@ -11,7 +11,7 @@
"dependencies": {
"clsx": "^2.1.1",
"fflate": "^0.8.2",
"lamejs": "^1.2.1",
"lamejs": "github:zhuker/lamejs",
"lucide-react": "^0.553.0",
"next": "^16.0.0",
"react": "^19.0.0",

11
pnpm-lock.yaml generated
View File

@@ -15,8 +15,8 @@ importers:
specifier: ^0.8.2
version: 0.8.2
lamejs:
specifier: ^1.2.1
version: 1.2.1
specifier: github:zhuker/lamejs
version: https://codeload.github.com/zhuker/lamejs/tar.gz/582bbba6a12f981b984d8fb9e1874499fed85675
lucide-react:
specifier: ^0.553.0
version: 0.553.0(react@19.2.0)
@@ -1384,8 +1384,9 @@ packages:
keyv@4.5.4:
resolution: {integrity: sha512-oxVHkHR/EJf2CNXnWxRLW6mg7JyCCUcG0DtEGmL2ctUo1PNTin1PUil+r/+4r5MpVgC/fn1kjsx7mjSujKqIpw==}
lamejs@1.2.1:
resolution: {integrity: sha512-s7bxvjvYthw6oPLCm5pFxvA84wUROODB8jEO2+CE1adhKgrIvVOlmMgY8zyugxGrvRaDHNJanOiS21/emty6dQ==}
lamejs@https://codeload.github.com/zhuker/lamejs/tar.gz/582bbba6a12f981b984d8fb9e1874499fed85675:
resolution: {tarball: https://codeload.github.com/zhuker/lamejs/tar.gz/582bbba6a12f981b984d8fb9e1874499fed85675}
version: 1.2.1
language-subtag-registry@0.3.23:
resolution: {integrity: sha512-0K65Lea881pHotoGEa5gDlMxt3pctLi2RplBb7Ezh4rRdLEOtgi7n4EwK9lamnUCkKBqaeKRVebTq6BAxSkpXQ==}
@@ -3412,7 +3413,7 @@ snapshots:
dependencies:
json-buffer: 3.0.1
lamejs@1.2.1:
lamejs@https://codeload.github.com/zhuker/lamejs/tar.gz/582bbba6a12f981b984d8fb9e1874499fed85675:
dependencies:
use-strict: 1.0.1