From 6fc0a84dfeac83d7ff4bcc29d60c3f7198247329 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Kr=C3=BCger?= Date: Mon, 1 Jun 2026 13:27:55 +0200 Subject: [PATCH] Fix song/application access: property not method call ControlSurface exposes song and application as properties, not callable methods. Replace manager.song() and manager.application() with the correct attribute access throughout handler, application, browser, and view modules. Co-Authored-By: Claude Sonnet 4.6 --- AbletonOSC/application.py | 2 +- AbletonOSC/browser.py | 2 +- AbletonOSC/handler.py | 2 +- AbletonOSC/view.py | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/AbletonOSC/application.py b/AbletonOSC/application.py index 3318e75..1a01bfc 100644 --- a/AbletonOSC/application.py +++ b/AbletonOSC/application.py @@ -17,7 +17,7 @@ class ApplicationHandler(AbletonOSCHandler): def _app(self): try: - return self.manager.application() + return self.manager.application except Exception: return None diff --git a/AbletonOSC/browser.py b/AbletonOSC/browser.py index 7c3cfb1..3bbf94b 100644 --- a/AbletonOSC/browser.py +++ b/AbletonOSC/browser.py @@ -46,7 +46,7 @@ class BrowserHandler(AbletonOSCHandler): def _browser(self): try: - return self.manager.application().browser + return self.manager.application.browser except Exception: return None diff --git a/AbletonOSC/handler.py b/AbletonOSC/handler.py index dc87a6c..ac657d7 100644 --- a/AbletonOSC/handler.py +++ b/AbletonOSC/handler.py @@ -14,7 +14,7 @@ class AbletonOSCHandler: @property def song(self): - return self.manager.song() + return self.manager.song # ------------------------------------------------------------------ # Registration helpers diff --git a/AbletonOSC/view.py b/AbletonOSC/view.py index 9608741..95be033 100644 --- a/AbletonOSC/view.py +++ b/AbletonOSC/view.py @@ -184,7 +184,7 @@ class ViewHandler(AbletonOSCHandler): def _show_clip_detail_view(self, params: tuple) -> None: try: - app = self.manager.application() + app = self.manager.application app.view.show_view("Detail/Clip") except Exception as e: logger.warning("show_clip_detail_view: %s", e) @@ -192,7 +192,7 @@ class ViewHandler(AbletonOSCHandler): def _show_device_detail_view(self, params: tuple) -> None: try: - app = self.manager.application() + app = self.manager.application app.view.show_view("Detail/DeviceChain") except Exception as e: logger.warning("show_device_detail_view: %s", e) @@ -200,7 +200,7 @@ class ViewHandler(AbletonOSCHandler): def _focus_browser(self, params: tuple) -> None: try: - app = self.manager.application() + app = self.manager.application app.view.show_view("Browser") except Exception as e: logger.warning("focus_browser: %s", e) @@ -208,7 +208,7 @@ class ViewHandler(AbletonOSCHandler): def _get_focused_document_view(self, params: tuple) -> Optional[tuple]: try: - app = self.manager.application() + app = self.manager.application view = app.view.focused_document_view return (view,) except Exception as e: